Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2226523002: Add separate plumbing for subresources with certificate errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix typo Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/public/browser/ssl_host_state_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 26e6d0a1768a028b7e8fab6b4c62e8a64d574b45..c9168177f7b3e01edf1b2c3c8f0b90f0c16aff9b 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -407,6 +407,7 @@ WebContentsImpl::WebContentsImpl(BrowserContext* browser_context)
upload_position_(0),
is_resume_pending_(false),
displayed_insecure_content_(false),
+ displayed_content_with_certificate_errors_(false),
has_accessed_initial_document_(false),
theme_color_(SK_ColorTRANSPARENT),
last_sent_theme_color_(SK_ColorTRANSPARENT),
@@ -1185,6 +1186,10 @@ bool WebContentsImpl::DisplayedInsecureContent() const {
return displayed_insecure_content_;
}
+bool WebContentsImpl::DisplayedContentWithCertificateErrors() const {
+ return displayed_content_with_certificate_errors_;
+}
+
void WebContentsImpl::IncrementCapturerCount(const gfx::Size& capture_size) {
DCHECK(!is_being_destroyed_);
++capturer_count_;
@@ -3378,6 +3383,7 @@ void WebContentsImpl::DidNavigateMainFramePostCommit(
// Once the main frame is navigated, we're no longer considered to have
// displayed insecure content.
displayed_insecure_content_ = false;
+ displayed_content_with_certificate_errors_ = false;
SSLManager::NotifySSLInternalStateChanged(
GetController().GetBrowserContext());
}
@@ -3510,7 +3516,7 @@ void WebContentsImpl::OnDidDisplayContentWithCertificateErrors(
if (!entry || !entry->GetURL().SchemeIsCryptographic())
return;
- displayed_insecure_content_ = true;
+ displayed_content_with_certificate_errors_ = true;
SSLManager::NotifySSLInternalStateChanged(
GetController().GetBrowserContext());
}
@@ -3527,7 +3533,8 @@ void WebContentsImpl::OnDidRunContentWithCertificateErrors(
// TODO(estark): check that this does something reasonable for
// about:blank and sandboxed origins. https://crbug.com/609527
- controller_.ssl_manager()->DidRunInsecureContent(entry->GetURL().GetOrigin());
+ controller_.ssl_manager()->DidRunContentWithCertificateErrors(
+ entry->GetURL().GetOrigin());
SSLManager::NotifySSLInternalStateChanged(
GetController().GetBrowserContext());
}
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/public/browser/ssl_host_state_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698