Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1221)

Unified Diff: media/filters/stream_parser_factory.cc

Issue 2226443002: Support multiple media tracks in MSE / ChunkDemuxer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mp4 format is not supported on some trybots, so use webm Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/stream_parser_factory.cc
diff --git a/media/filters/stream_parser_factory.cc b/media/filters/stream_parser_factory.cc
index 5a95322bed0e06e861c6fe6dc8d44bac7f60d8f4..c67886aa84b9a27ddfb59480668e53969582719f 100644
--- a/media/filters/stream_parser_factory.cc
+++ b/media/filters/stream_parser_factory.cc
@@ -463,21 +463,14 @@ bool StreamParserFactory::IsTypeSupported(
std::unique_ptr<StreamParser> StreamParserFactory::Create(
const std::string& type,
const std::vector<std::string>& codecs,
- const scoped_refptr<MediaLog>& media_log,
- bool* has_audio,
- bool* has_video) {
+ const scoped_refptr<MediaLog>& media_log) {
std::unique_ptr<StreamParser> stream_parser;
ParserFactoryFunction factory_function;
std::vector<CodecInfo::HistogramTag> audio_codecs;
std::vector<CodecInfo::HistogramTag> video_codecs;
- *has_audio = false;
- *has_video = false;
if (CheckTypeAndCodecs(type, codecs, media_log, &factory_function,
&audio_codecs, &video_codecs)) {
- *has_audio = !audio_codecs.empty();
- *has_video = !video_codecs.empty();
-
// Log the number of codecs specified, as well as the details on each one.
UMA_HISTOGRAM_COUNTS_100("Media.MSE.NumberOfTracks", codecs.size());
for (size_t i = 0; i < audio_codecs.size(); ++i) {

Powered by Google App Engine
This is Rietveld 408576698