Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 2226413002: Clean up Xlib viewer (Closed)

Created:
4 years, 4 months ago by jvanverth1
Modified:
4 years, 4 months ago
Reviewers:
bsalomon, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Clean up Xlib viewer * Make event handling closer to GLFW's * Fix Vulkan refreshing BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2226413002 Committed: https://skia.googlesource.com/skia/+/8c67ebe4c48028635e7fe34542344e0ca7006b23

Patch Set 1 #

Patch Set 2 : main cleanup #

Patch Set 3 : More cleanup #

Patch Set 4 : Fix non-vulkan build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M tools/viewer/Viewer.cpp View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download
M tools/viewer/sk_app/VulkanWindowContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tools/viewer/sk_app/unix/main_unix.cpp View 1 3 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
jvanverth1
4 years, 4 months ago (2016-08-09 20:04:39 UTC) #5
bsalomon
lgtm
4 years, 4 months ago (2016-08-09 20:09:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226413002/40001
4 years, 4 months ago (2016-08-10 13:23:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/10487)
4 years, 4 months ago (2016-08-10 13:28:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226413002/60001
4 years, 4 months ago (2016-08-11 13:42:22 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 14:03:11 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/8c67ebe4c48028635e7fe34542344e0ca7006b23

Powered by Google App Engine
This is Rietveld 408576698