Issue 22264018: Removed memory leak suppression for ShConstructCompiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22264018: Removed memory leak suppression for ShConstructCompiler. (Closed)

Created:
7 years, 4 months ago by alokp

Modified:
7 years, 4 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Removed memory leak suppression for ShConstructCompiler. The leak happened when building built-in symbol table. We have recently completely refactored the way initial symbol-table is built. We no longer parse string. The symbols are manually allocated and inserted. BUG=109495 R=kbr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217031

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -8 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

alokp

7 years, 4 months ago (2013-08-12 17:46:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r217031 (presubmit successful).

Expand Messages | Collapse Messages