Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2226333002: [Interpreter] Avoid allocating handles in bytecode-array-writer (Closed)

Created:
4 years, 4 months ago by rmcilroy
Modified:
4 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@offheap_varchecks
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Avoid allocating handles in bytecode-array-writer Don't allocate handles in the bytecode array writer, to allow off-thread bytecode generation. BUG=v8:5203 Committed: https://crrev.com/d1ab9f126c7c8b145d6a5bc88c64b0e77c9d8968 Cr-Commit-Position: refs/heads/master@{#38550}

Patch Set 1 #

Patch Set 2 : [Interpreter] Avoid allocating handles in bytecode-array-writer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -93 lines) Patch
M src/interpreter/bytecode-array-writer.cc View 1 2 chunks +2 lines, -6 lines 0 comments Download
M src/interpreter/constant-array-builder.h View 3 chunks +5 lines, -2 lines 0 comments Download
M src/interpreter/constant-array-builder.cc View 4 chunks +24 lines, -7 lines 0 comments Download
M test/unittests/interpreter/constant-array-builder-unittest.cc View 7 chunks +91 lines, -78 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
rmcilroy
Michi, please take a look, thanks.
4 years, 4 months ago (2016-08-10 08:52:23 UTC) #6
Michael Starzinger
LGTM.
4 years, 4 months ago (2016-08-10 16:01:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226333002/20001
4 years, 4 months ago (2016-08-10 16:16:03 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-10 16:41:48 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 16:42:15 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d1ab9f126c7c8b145d6a5bc88c64b0e77c9d8968
Cr-Commit-Position: refs/heads/master@{#38550}

Powered by Google App Engine
This is Rietveld 408576698