Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: headless/lib/headless_devtools_client_browsertest.cc

Issue 2226323002: Resize DevTools target frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't expose WebContents through HeadlessWebContents. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: headless/lib/headless_devtools_client_browsertest.cc
diff --git a/headless/lib/headless_devtools_client_browsertest.cc b/headless/lib/headless_devtools_client_browsertest.cc
index 9eb22d10abb2367addd18a2beb2fab4c4f411a7d..1755b10596d5c1ae3ebbf41b290473547af8bf59 100644
--- a/headless/lib/headless_devtools_client_browsertest.cc
+++ b/headless/lib/headless_devtools_client_browsertest.cc
@@ -212,10 +212,22 @@ class BrowserDomainCreateAndDeletePageTest
std::unique_ptr<browser::CreateTargetResult> result) {
EXPECT_EQ(2u, GetAllWebContents(browser()).size());
- devtools_client_->GetBrowser()->GetExperimental()->CloseTarget(
- browser::CloseTargetParams::Builder()
+ devtools_client_->GetBrowser()->GetExperimental()->GetFrameSize(
+ browser::GetFrameSizeParams::Builder()
.SetTargetId(result->GetTargetId())
.Build(),
+ base::Bind(&BrowserDomainCreateAndDeletePageTest::OnGetFrameSizeResult,
+ base::Unretained(this), result->GetTargetId()));
+ }
+
+ void OnGetFrameSizeResult(
+ std::string target_id,
+ std::unique_ptr<browser::GetFrameSizeResult> result) {
+ EXPECT_EQ(1, result->GetWidth());
+ EXPECT_EQ(1, result->GetHeight());
+
+ devtools_client_->GetBrowser()->GetExperimental()->CloseTarget(
+ browser::CloseTargetParams::Builder().SetTargetId(target_id).Build(),
base::Bind(&BrowserDomainCreateAndDeletePageTest::OnCloseTargetResult,
base::Unretained(this)));
}

Powered by Google App Engine
This is Rietveld 408576698