Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2356)

Unified Diff: headless/lib/headless_devtools_client_browsertest.cc

Issue 2226323002: Resize DevTools target frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename, add tests, fix comments/style, add support in shell. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: headless/lib/headless_devtools_client_browsertest.cc
diff --git a/headless/lib/headless_devtools_client_browsertest.cc b/headless/lib/headless_devtools_client_browsertest.cc
index 9eb22d10abb2367addd18a2beb2fab4c4f411a7d..7245ebea5f73328b0c3df61de162040605fa0205 100644
--- a/headless/lib/headless_devtools_client_browsertest.cc
+++ b/headless/lib/headless_devtools_client_browsertest.cc
@@ -5,6 +5,8 @@
#include <memory>
#include "base/json/json_reader.h"
+#include "content/public/browser/render_widget_host_view.h"
+#include "content/public/browser/web_contents.h"
#include "content/public/test/browser_test.h"
#include "headless/public/domains/browser.h"
#include "headless/public/domains/network.h"
@@ -14,8 +16,15 @@
#include "headless/public/headless_devtools_client.h"
#include "headless/test/headless_browser_test.h"
#include "testing/gtest/include/gtest/gtest.h"
+#include "ui/gfx/geometry/size.h"
#include "url/gurl.h"
+#define EXPECT_SIZE_EQ(expected, actual) \
+ do { \
+ EXPECT_EQ((expected).width(), (actual).width()); \
+ EXPECT_EQ((expected).height(), (actual).height()); \
+ } while (false)
+
namespace headless {
namespace {
@@ -212,6 +221,12 @@ class BrowserDomainCreateAndDeletePageTest
std::unique_ptr<browser::CreateTargetResult> result) {
EXPECT_EQ(2u, GetAllWebContents(browser()).size());
+ content::WebContents* web_contents =
+ GetAllWebContents(browser()).back()->GetWebContents();
+ EXPECT_SIZE_EQ(
+ gfx::Size(1, 1),
+ web_contents->GetRenderWidgetHostView()->GetViewBounds().size());
+
devtools_client_->GetBrowser()->GetExperimental()->CloseTarget(
browser::CloseTargetParams::Builder()
.SetTargetId(result->GetTargetId())

Powered by Google App Engine
This is Rietveld 408576698