Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: third_party/WebKit/Source/core/inspector/browser_protocol.json

Issue 2226323002: Resize DevTools target frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use MAYBE_ pattern to disable test on Android. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « headless/lib/headless_devtools_client_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/inspector/browser_protocol.json
diff --git a/third_party/WebKit/Source/core/inspector/browser_protocol.json b/third_party/WebKit/Source/core/inspector/browser_protocol.json
index ce03c4bfa78969fa3619ba513b29a9a595996973..9386a3dbd1153b4213fc944687d21c76d4f957c6 100644
--- a/third_party/WebKit/Source/core/inspector/browser_protocol.json
+++ b/third_party/WebKit/Source/core/inspector/browser_protocol.json
@@ -758,6 +758,24 @@
]
},
{
+ "name": "getFrameSize",
dgozman 2016/08/18 20:16:25 As you discussed with Pavel, let's remove this and
+ "description": "Returns the size of the target's (non-overridden) frame.",
+ "returns": [
+ { "name": "width", "type": "integer", "description": "Frame width (DIP)." },
+ { "name": "height", "type": "integer", "description": "Frame height (DIP)." }
+ ],
+ "handlers": ["browser"]
+ },
+ {
+ "name": "setFrameSize",
dgozman 2016/08/18 20:16:25 I'm worried this name is confusing as a part of pr
Eric Seckler 2016/08/18 22:04:40 I'd find it clearer if the command's name actually
dgozman 2016/08/19 17:52:29 I personally like setVisibleSize more, because it
+ "description": "Resize the target's frame. Note that this does not affect the frame's container (e.g. browser window). Not supported on Android.",
+ "parameters": [
+ { "name": "width", "type": "integer", "description": "Frame width (DIP)." },
+ { "name": "height", "type": "integer", "description": "Frame height (DIP)." }
+ ],
+ "handlers": ["browser"]
+ },
+ {
"name": "setScriptExecutionDisabled",
"description": "Switches script execution in the page.",
"parameters": [
« no previous file with comments | « headless/lib/headless_devtools_client_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698