Resize DevTools target frames.

components/devtools_discovery/devtools_discovery_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/devtools_discovery/devtools_discovery_manager.h"
 
 #include "base/stl_util.h"
 #include "components/devtools_discovery/basic_target_descriptor.h"
 #include "content/public/browser/devtools_agent_host.h"
+#include "content/public/browser/render_widget_host_view.h"
+#include "content/public/browser/web_contents.h"
 
 using content::DevToolsAgentHost;
+using content::WebContents;
+using content::RenderWidgetHostView;
 
 namespace devtools_discovery {
 
 // static
 DevToolsDiscoveryManager* DevToolsDiscoveryManager::GetInstance() {
   return base::Singleton<DevToolsDiscoveryManager>::get();
 }
 
 DevToolsDiscoveryManager::DevToolsDiscoveryManager() {
 }
@@ skipping 34 matching lines @@
 DevToolsDiscoveryManager::GetDescriptorsFromProviders() {
   DevToolsTargetDescriptor::List result;
   for (auto* provider : providers_) {
     DevToolsTargetDescriptor::List partial = provider->GetDescriptors();
     result.insert(result.begin(), partial.begin(), partial.end());
   }
   return result;
 }
 
 std::unique_ptr<base::DictionaryValue>
-DevToolsDiscoveryManager::HandleNewTargetCommand(
+DevToolsDiscoveryManager::HandleCreateTargetCommand(

[alex clarke (OOO till 29th), 2016/08/10 12:39:48]

Maybe mention in the patch comment that we don't need to change
HeadlessDevToolsManagerDelegate::CreateTarget because that already supports
width & height?

[Eric Seckler, 2016/08/10 12:57:06]

Done.

     base::DictionaryValue* command_dict) {
-  int id;
+  int id, width, height;
   std::string method;
   std::string url;
   const base::DictionaryValue* params_dict = nullptr;
   if (command_dict->GetInteger("id", &id) &&
       command_dict->GetString("method", &method) &&
       method == "Browser.createTarget" &&
       command_dict->GetDictionary("params", &params_dict) &&
       params_dict->GetString("url", &url)) {
     std::unique_ptr<devtools_discovery::DevToolsTargetDescriptor> descriptor =
         CreateNew(GURL(url));
     if (!descriptor)
       return nullptr;
+
+    // Set size of frame by resizing RWHV if available.
+    if (params_dict->GetInteger("width", &width) && width >= 0 &&
+        params_dict->GetInteger("height", &height) && height >= 0) {
+      scoped_refptr<DevToolsAgentHost> agent_host = descriptor->GetAgentHost();
+      WebContents* web_contents =
+          agent_host ? agent_host->GetWebContents() : nullptr;
+      RenderWidgetHostView* view =
+          web_contents ? web_contents->GetRenderWidgetHostView() : nullptr;
+      if (view)
+        view->SetSize(gfx::Size(width, height));
+    }
+
     std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue());
     result->SetInteger("id", id);
     std::unique_ptr<base::DictionaryValue> cmd_result(
         new base::DictionaryValue());
-    cmd_result->SetString("pageId", descriptor->GetId());
+    cmd_result->SetString("targetId", descriptor->GetId());
     result->Set("result", std::move(cmd_result));
     return result;
   }
   return nullptr;
 }
 
 }  // namespace devtools_discovery