Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 2226243002: Indirect Get*Scope over parser/parserbase (Closed)

Created:
4 years, 4 months ago by Toon Verwaest
Modified:
4 years, 4 months ago
Reviewers:
adamk, marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Indirect Get*Scope over parser/parserbase This avoids direct scope() accesses and allows us to redirect it over ScopeState. BUG=v8:5209 Committed: https://crrev.com/0904b84e45466fa70a4864a1eb195291fa2bc901 Cr-Commit-Position: refs/heads/master@{#38507}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
M src/parsing/parser.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/parsing/parser.cc View 7 chunks +8 lines, -11 lines 0 comments Download
M src/parsing/parser-base.h View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Toon Verwaest
ptal
4 years, 4 months ago (2016-08-09 11:49:44 UTC) #2
adamk
lgtm Love that these CLs not only are moving in a direction we like, but ...
4 years, 4 months ago (2016-08-09 17:37:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226243002/1
4 years, 4 months ago (2016-08-09 18:32:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 19:05:53 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 19:06:17 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0904b84e45466fa70a4864a1eb195291fa2bc901
Cr-Commit-Position: refs/heads/master@{#38507}

Powered by Google App Engine
This is Rietveld 408576698