Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2226223002: [ast][parser] Remove redundant Declaration::mode_. (Closed)

Created:
4 years, 4 months ago by neis
Modified:
4 years, 4 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com, Toon Verwaest
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ast][parser] Remove redundant Declaration::mode_. BUG= Committed: https://crrev.com/6e8a2d272288601a08d5ba2232d579749ed9ed52 Cr-Commit-Position: refs/heads/master@{#38519}

Patch Set 1 #

Patch Set 2 : Cosmetics. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -51 lines) Patch
M src/ast/ast.h View 4 chunks +11 lines, -21 lines 0 comments Download
M src/ast/prettyprinter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ast/scopes.cc View 1 2 4 chunks +7 lines, -6 lines 0 comments Download
M src/parsing/parser.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/parser.cc View 1 2 6 chunks +22 lines, -18 lines 0 comments Download
M src/parsing/pattern-rewriter.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
neis
PTAL
4 years, 4 months ago (2016-08-09 09:57:07 UTC) #5
adamk
lgtm This makes it even clearer that Declarations should have a Variable, not a VariableProxy.
4 years, 4 months ago (2016-08-09 16:44:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226223002/40001
4 years, 4 months ago (2016-08-10 07:47:22 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-10 08:10:29 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 08:10:56 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6e8a2d272288601a08d5ba2232d579749ed9ed52
Cr-Commit-Position: refs/heads/master@{#38519}

Powered by Google App Engine
This is Rietveld 408576698