Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2226213002: trial_token_unittest: Document how to use or update the public key. (Closed)

Created:
4 years, 4 months ago by Matt Giuca
Modified:
4 years, 4 months ago
Reviewers:
iclelland
CC:
chromium-reviews, jam, darin-cc_chromium.org, chasej+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

trial_token_unittest: Document how to use or update the public key. Provides instruction for anyone changing the test public/private key pair that they have to update the corresponding private key file. Also provides a comment with the base-64-encoded public key, so we can instruct users how to use this key from the command line. BUG=635791 Committed: https://crrev.com/3b9774cf8fb53ada294e332a77111ce1f92ab9a1 Cr-Commit-Position: refs/heads/master@{#410982}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/common/origin_trials/trial_token_unittest.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Matt Giuca
Hi, I will also send out a PR to update the documentation here: https://github.com/jpchase/OriginTrials/blob/gh-pages/ship-as-trial.md But ...
4 years, 4 months ago (2016-08-09 08:04:53 UTC) #2
Matt Giuca
4 years, 4 months ago (2016-08-09 08:05:12 UTC) #3
iclelland
Thanks! This LGTM
4 years, 4 months ago (2016-08-09 11:44:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226213002/1
4 years, 4 months ago (2016-08-10 05:49:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 06:32:41 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 06:34:03 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b9774cf8fb53ada294e332a77111ce1f92ab9a1
Cr-Commit-Position: refs/heads/master@{#410982}

Powered by Google App Engine
This is Rietveld 408576698