Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: gpu/ipc/client/command_buffer_proxy_impl.cc

Issue 2226193002: Not for commit: crash GPU process in glCreateGpuMemoryBufferImageCHROMIUM. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/client/gles2_implementation.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/ipc/client/command_buffer_proxy_impl.cc
diff --git a/gpu/ipc/client/command_buffer_proxy_impl.cc b/gpu/ipc/client/command_buffer_proxy_impl.cc
index faf69b980ed8cbc2567353d7faaf7d3c9290e6ed..b9ccce12a6a6ca1c08b53953cc2cccde913e90ca 100644
--- a/gpu/ipc/client/command_buffer_proxy_impl.cc
+++ b/gpu/ipc/client/command_buffer_proxy_impl.cc
@@ -522,8 +522,12 @@ int32_t CommandBufferProxyImpl::CreateGpuMemoryBufferImage(
gfx::Size(width, height),
gpu::DefaultBufferFormatForImageFormat(internal_format),
gfx::BufferUsage::SCANOUT, gpu::kNullSurfaceHandle));
- if (!buffer)
+ if (!buffer) {
+ fprintf(stderr, "CommandBufferProxyImpl::CreateGpuMemoryBufferImage: no buffer from AllocateGpuMemoryBuffer\n");
return -1;
+ } else {
+ fprintf(stderr, "CommandBufferProxyImpl::CreateGpuMemoryBufferImage: got a buffer\n");
+ }
int32_t result =
CreateImage(buffer->AsClientBuffer(), width, height, internal_format);
« no previous file with comments | « gpu/command_buffer/client/gles2_implementation.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698