Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

Issue 2226163002: DevTools: do not use string templates in front-end, minifier is confused. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 626 matching lines...) Expand 10 before | Expand all | Expand 10 after
637 } 637 }
638 638
639 /** 639 /**
640 * @param {!Array<{filterType: !WebInspector.NetworkLogView.FilterType, filterVa lue: string}>} filters 640 * @param {!Array<{filterType: !WebInspector.NetworkLogView.FilterType, filterVa lue: string}>} filters
641 */ 641 */
642 WebInspector.NetworkPanel.revealAndFilter = function(filters) 642 WebInspector.NetworkPanel.revealAndFilter = function(filters)
643 { 643 {
644 var panel = WebInspector.NetworkPanel._instance(); 644 var panel = WebInspector.NetworkPanel._instance();
645 var filterString = ""; 645 var filterString = "";
646 for (var filter of filters) 646 for (var filter of filters)
647 filterString += `${filter.filterType}:${filter.filterValue} `; 647 filterString += filter.filterType + ":" + filter.filterValue + " ";
648 panel._networkLogView.setTextFilterValue(filterString); 648 panel._networkLogView.setTextFilterValue(filterString);
649 WebInspector.inspectorView.setCurrentPanel(panel); 649 WebInspector.inspectorView.setCurrentPanel(panel);
650 } 650 }
651 651
652 /** 652 /**
653 * @return {!WebInspector.NetworkPanel} 653 * @return {!WebInspector.NetworkPanel}
654 */ 654 */
655 WebInspector.NetworkPanel._instance = function() 655 WebInspector.NetworkPanel._instance = function()
656 { 656 {
657 return /** @type {!WebInspector.NetworkPanel} */ (self.runtime.sharedInstanc e(WebInspector.NetworkPanel)); 657 return /** @type {!WebInspector.NetworkPanel} */ (self.runtime.sharedInstanc e(WebInspector.NetworkPanel));
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
770 * @return {boolean} 770 * @return {boolean}
771 */ 771 */
772 handleAction: function(context, actionId) 772 handleAction: function(context, actionId)
773 { 773 {
774 var panel = WebInspector.context.flavor(WebInspector.NetworkPanel); 774 var panel = WebInspector.context.flavor(WebInspector.NetworkPanel);
775 console.assert(panel && panel instanceof WebInspector.NetworkPanel); 775 console.assert(panel && panel instanceof WebInspector.NetworkPanel);
776 panel._toggleRecording(); 776 panel._toggleRecording();
777 return true; 777 return true;
778 } 778 }
779 } 779 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698