device/geolocation/BUILD.gn - Issue 2226143002: Gets rid of the LocationArbitrator interface, in preference for LocationProvider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/geolocation/BUILD.gn

Issue 2226143002: Gets rid of the LocationArbitrator interface, in preference for LocationProvider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into lai Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/engine/feature/geolocation/engine_geolocation_feature_unittest.cc ('k') | device/geolocation/geolocation_provider_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/geolocation/BUILD.gn

diff --git a/device/geolocation/BUILD.gn b/device/geolocation/BUILD.gn

index 8bd0611d112961ce8a8675dc6391fda6c5db4a89..0e4c4357bb0de899fb081f6616831d95832a70c4 100644

--- a/device/geolocation/BUILD.gn

+++ b/device/geolocation/BUILD.gn

@@ -31,7 +31,6 @@ component("device_geolocation") {

"geoposition.h",

"location_api_adapter_android.cc",

"location_api_adapter_android.h",

- "location_arbitrator.h",

"location_arbitrator_impl.cc",

"location_arbitrator_impl.h",

"location_provider.h",

@@ -155,8 +154,6 @@ source_set("unittests") {

"fake_access_token_store.h",

"geolocation_provider_impl_unittest.cc",

"location_arbitrator_impl_unittest.cc",

- "mock_location_arbitrator.cc",

- "mock_location_arbitrator.h",

"mock_location_provider.cc",

"mock_location_provider.h",

"network_location_provider_unittest.cc",