blimp/engine/feature/geolocation/blimp_location_provider_unittest.cc - Issue 2226143002: Gets rid of the LocationArbitrator interface, in preference for LocationProvider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/engine/feature/geolocation/blimp_location_provider_unittest.cc

Issue 2226143002: Gets rid of the LocationArbitrator interface, in preference for LocationProvider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into lai Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/engine/feature/geolocation/blimp_location_provider.cc ('k') | blimp/engine/feature/geolocation/engine_geolocation_feature_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/engine/feature/geolocation/blimp_location_provider_unittest.cc

diff --git a/blimp/engine/feature/geolocation/blimp_location_provider_unittest.cc b/blimp/engine/feature/geolocation/blimp_location_provider_unittest.cc

index 1e944c6219695f68767316020fc583116f1a4bda..2fe69b3815798e8ebe616353d2a1cd5ac8a626c7 100644

--- a/blimp/engine/feature/geolocation/blimp_location_provider_unittest.cc

+++ b/blimp/engine/feature/geolocation/blimp_location_provider_unittest.cc

@@ -106,22 +106,7 @@ TEST_F(BlimpLocationProviderTest, LocationProviderDeleted) {

location_provider_.reset();

}

-TEST_F(BlimpLocationProviderTest, RequestRefreshRunsCorrectly) {

- EXPECT_CALL(*delegate_, RequestRefresh()).Times(1);

- location_provider_->StartProvider(true);

- location_provider_->RequestRefresh();

-TEST_F(BlimpLocationProviderTest, RequestRefreshHandlesNullDelegate) {

- EXPECT_CALL(*delegate_, RequestRefresh()).Times(0);

- location_provider_->StartProvider(true);

- delegate_.reset();

- location_provider_->RequestRefresh();

-TEST_F(BlimpLocationProviderTest, OnPermissionGrantedCallsRefresh) {

+TEST_F(BlimpLocationProviderTest, OnPermissionGranted) {

EXPECT_CALL(*delegate_, RequestRefresh()).Times(1);

location_provider_->StartProvider(true);