blimp/engine/feature/geolocation/blimp_location_provider.h - Issue 2226143002: Gets rid of the LocationArbitrator interface, in preference for LocationProvider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/engine/feature/geolocation/blimp_location_provider.h

Issue 2226143002: Gets rid of the LocationArbitrator interface, in preference for LocationProvider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into lai Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/engine/feature/geolocation/blimp_location_provider.h

diff --git a/blimp/engine/feature/geolocation/blimp_location_provider.h b/blimp/engine/feature/geolocation/blimp_location_provider.h

index d5ffe5ac23ee459b4b1a8a39371a6ed49716b306..3f23ce7d61859a02dbf8ed36fe7b0c16c267fb79 100644

--- a/blimp/engine/feature/geolocation/blimp_location_provider.h

+++ b/blimp/engine/feature/geolocation/blimp_location_provider.h

@@ -37,8 +37,7 @@ class BlimpLocationProvider : public device::LocationProvider {

// device::LocationProvider implementation.

bool StartProvider(bool high_accuracy) override;

void StopProvider() override;

- void GetPosition(device::Geoposition* position) override;

- void RequestRefresh() override;

+ const device::Geoposition& GetPosition() override;

void OnPermissionGranted() override;

void SetUpdateCallback(

const LocationProviderUpdateCallback& callback) override;

« no previous file with comments | « no previous file | blimp/engine/feature/geolocation/blimp_location_provider.cc » ('j') | no next file with comments »