blimp/engine/feature/geolocation/engine_geolocation_feature.cc - Issue 2226143002: Gets rid of the LocationArbitrator interface, in preference for LocationProvider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/engine/feature/geolocation/engine_geolocation_feature.cc

Issue 2226143002: Gets rid of the LocationArbitrator interface, in preference for LocationProvider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: In response to Wez's #73-75 comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/engine/feature/geolocation/blimp_location_provider.h ('K') | « blimp/engine/feature/geolocation/engine_geolocation_feature.h ('k') | blimp/engine/feature/geolocation/engine_geolocation_feature_unittest.cc » ('j') | device/geolocation/mock_location_provider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/engine/feature/geolocation/engine_geolocation_feature.cc

diff --git a/blimp/engine/feature/geolocation/engine_geolocation_feature.cc b/blimp/engine/feature/geolocation/engine_geolocation_feature.cc

index 5e8e9e804dba5ce9ea51916455acc0928bd6ff01..f792b5fbcf1c409a11299536e89883ce080308ba 100644

--- a/blimp/engine/feature/geolocation/engine_geolocation_feature.cc

+++ b/blimp/engine/feature/geolocation/engine_geolocation_feature.cc

@@ -137,7 +137,7 @@ void EngineGeolocationFeature::RequestAccuracy(

net::CompletionCallback());

}

-void EngineGeolocationFeature::RequestRefresh() {

+void EngineGeolocationFeature::OnPermissionGranted() {

GeolocationMessage* geolocation_message = nullptr;

std::unique_ptr<BlimpMessage> blimp_message =

CreateBlimpMessage(&geolocation_message);