Gets rid of the LocationArbitrator interface, in preference for LocationProvider.

device/geolocation/network_location_provider.h

Index: device/geolocation/network_location_provider.h
diff --git a/device/geolocation/network_location_provider.h b/device/geolocation/network_location_provider.h
index f47310425789ad83277d07f3a746df95302cbd51..9df56c49717efbbd4cd7667698dce4772bcb2397 100644
--- a/device/geolocation/network_location_provider.h
+++ b/device/geolocation/network_location_provider.h
@@ -73,11 +73,14 @@ class NetworkLocationProvider : public base::NonThreadSafe,
   // LocationProvider implementation
   bool StartProvider(bool high_accuracy) override;
   void StopProvider() override;
-  void GetPosition(Geoposition* position) override;
-  void RequestRefresh() override;
+  const Geoposition& GetPosition() override;
   void OnPermissionGranted() override;
 
  private:
+  // Provides a hint to the provider that new location data is needed as soon
+  // as possible.
+  void RequestRefresh();

[Wez, 2016/08/19 01:33:12]

This comment implies that external callers provide that hint, which they can't -
this is now an implementation detail and it's called to ensure we get frash
location data when permission is granted or the wi-fi state changes.

It's also worth considering whether the two tests in RequestRefresh could just
be folded into RequestPosition().

[CJ, 2016/08/22 17:41:31]

Done. Which tests are you talking about? (Not seeing them).

[Wez, 2016/08/24 04:13:17]

All that RequestRefresh() does is:

   if (!weak_factory_.HasWeakPtrs() || is_wifi_data_complete_) {
   RequestPosition()
  }

So can we just move that if() into RequestPosition() and get rid of
RequestRefresh()?  Would that break anything?

[CJ, 2016/08/24 21:32:05]

Doesnt seem to.

+
   // Satisfies a position request from cache or network.
   void RequestPosition();