Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2749)

Unified Diff: device/geolocation/network_location_provider_unittest.cc

Issue 2226143002: Gets rid of the LocationArbitrator interface, in preference for LocationProvider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses kmarshall's #41 comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/geolocation/network_location_provider_unittest.cc
diff --git a/device/geolocation/network_location_provider_unittest.cc b/device/geolocation/network_location_provider_unittest.cc
index c27c1dd21e98b7e94de3195a7d199f811e72f9d1..af78bb05ba80c61004032389fc9c1f74799238c5 100644
--- a/device/geolocation/network_location_provider_unittest.cc
+++ b/device/geolocation/network_location_provider_unittest.cc
@@ -381,8 +381,7 @@ TEST_F(GeolocationNetworkProviderTest, MultipleWifiScansComplete) {
fetcher->SetResponseString(kNoFixNetworkResponse);
fetcher->delegate()->OnURLFetchComplete(fetcher);
- Geoposition position;
- provider->GetPosition(&position);
+ Geoposition position = provider->GetPosition();
EXPECT_FALSE(position.Validate());
// Now wifi data arrives -- SetData will notify listeners.
@@ -411,7 +410,7 @@ TEST_F(GeolocationNetworkProviderTest, MultipleWifiScansComplete) {
fetcher->SetResponseString(kReferenceNetworkResponse);
fetcher->delegate()->OnURLFetchComplete(fetcher);
- provider->GetPosition(&position);
+ position = provider->GetPosition();
EXPECT_EQ(51.0, position.latitude);
EXPECT_EQ(-0.1, position.longitude);
EXPECT_EQ(1200.4, position.accuracy);
@@ -430,7 +429,7 @@ TEST_F(GeolocationNetworkProviderTest, MultipleWifiScansComplete) {
fetcher = get_url_fetcher_and_advance_id();
EXPECT_FALSE(fetcher);
- provider->GetPosition(&position);
+ position = provider->GetPosition();
EXPECT_EQ(51.0, position.latitude);
EXPECT_EQ(-0.1, position.longitude);
EXPECT_TRUE(position.Validate());
@@ -451,7 +450,7 @@ TEST_F(GeolocationNetworkProviderTest, MultipleWifiScansComplete) {
fetcher->delegate()->OnURLFetchComplete(fetcher);
// Error means we now no longer have a fix.
- provider->GetPosition(&position);
+ position = provider->GetPosition();
EXPECT_FALSE(position.Validate());
// Wifi scan returns to original set: should be serviced from cache.
@@ -459,7 +458,7 @@ TEST_F(GeolocationNetworkProviderTest, MultipleWifiScansComplete) {
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(get_url_fetcher_and_advance_id()); // No new request created.
- provider->GetPosition(&position);
+ position = provider->GetPosition();
EXPECT_EQ(51.0, position.latitude);
EXPECT_EQ(-0.1, position.longitude);
EXPECT_TRUE(position.Validate());

Powered by Google App Engine
This is Rietveld 408576698