Gets rid of the LocationArbitrator interface, in preference for LocationProvider.

blimp/engine/feature/geolocation/blimp_location_provider.cc

Index: blimp/engine/feature/geolocation/blimp_location_provider.cc
diff --git a/blimp/engine/feature/geolocation/blimp_location_provider.cc b/blimp/engine/feature/geolocation/blimp_location_provider.cc
index eed675f8b45460592e693de4fdb6e6407a642466..814153b42cc4ed3491d683240799a921a1d8de90 100644
--- a/blimp/engine/feature/geolocation/blimp_location_provider.cc
+++ b/blimp/engine/feature/geolocation/blimp_location_provider.cc
@@ -44,8 +44,8 @@ void BlimpLocationProvider::StopProvider() {
   }
 }
 
-void BlimpLocationProvider::GetPosition(device::Geoposition* position) {
-  *position = cached_position_;
+const device::Geoposition& BlimpLocationProvider::GetPosition() {
+  return cached_position_;
 }
 
 void BlimpLocationProvider::RequestRefresh() {

[Wez, 2016/08/19 01:33:11]

Nothing calls this API except OnPermissionGranted, so how about just moving this
code there, and removing this method?

What does the delegate's RequestRefresh() actually do, though? Is there any
point calling it? Should it be an explicit OnPermissionGranted method as well?

[CJ, 2016/08/22 17:41:31]

In most cases RequestRefresh() is only called by OnPermissionGranted or private
classes, so for this case I think its fine to just move it to
OnPermissionGranted. As for changing the delegate, right now I don't see
anything that should keep it as RequestRefresh either. If we do this though, do
we want to change the message too? I'm reluctant because that is what we are
doing on OnPermissionGranted(), requesting a refresh, but it also makes sense to
do it since the client right now processes it into a OnPermissionGranted call
anyway. What do you think?