device/geolocation/geolocation_provider_impl_unittest.cc - Issue 2226143002: Gets rid of the LocationArbitrator interface, in preference for LocationProvider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/geolocation/geolocation_provider_impl_unittest.cc

Issue 2226143002: Gets rid of the LocationArbitrator interface, in preference for LocationProvider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removes LocationArbitrator.h Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« device/geolocation/geolocation_provider_impl.h ('K') | « device/geolocation/geolocation_provider_impl.cc ('k') | device/geolocation/location_arbitrator.h » ('j') | device/geolocation/location_arbitrator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/geolocation/geolocation_provider_impl_unittest.cc

diff --git a/device/geolocation/geolocation_provider_impl_unittest.cc b/device/geolocation/geolocation_provider_impl_unittest.cc

index 5eb1af9d34ede9a699fdc386c768015e4d035216..8478c1e3e7ee9b67aa2eb9dad7e7b7fb5f4ff143 100644

--- a/device/geolocation/geolocation_provider_impl_unittest.cc

+++ b/device/geolocation/geolocation_provider_impl_unittest.cc

@@ -38,14 +38,14 @@ class LocationProviderForTestArbitrator : public GeolocationProviderImpl {

protected:

// GeolocationProviderImpl implementation:

- std::unique_ptr<LocationArbitrator> CreateArbitrator() override;

+ std::unique_ptr<LocationProvider> CreateArbitrator() override;

private:

// An alias to the arbitrator stored in the super class, where it is owned.

MockLocationArbitrator* mock_arbitrator_;

};

-std::unique_ptr<LocationArbitrator>

+std::unique_ptr<LocationProvider>

LocationProviderForTestArbitrator::CreateArbitrator() {

DCHECK(mock_arbitrator_ == NULL);

mock_arbitrator_ = new MockLocationArbitrator;