Gets rid of the LocationArbitrator interface, in preference for LocationProvider.

device/geolocation/location_arbitrator_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DEVICE_GEOLOCATION_LOCATION_ARBITRATOR_IMPL_H_
 #define DEVICE_GEOLOCATION_LOCATION_ARBITRATOR_IMPL_H_
 
 #include <stdint.h>
+#include <memory>

[Wez, 2016/08/09 01:17:04]

What's this extra include needed for?

[CJ, 2016/08/11 22:06:43]

Lint complains without it. It's because we are using unique_ptrs.

 #include <vector>
 
 #include "base/callback_forward.h"
 #include "base/cancelable_callback.h"
 #include "base/macros.h"
 #include "base/memory/scoped_vector.h"
 #include "base/strings/string16.h"
 #include "base/time/time.h"
 #include "device/geolocation/access_token_store.h"
 #include "device/geolocation/geolocation_export.h"
 #include "device/geolocation/geolocation_provider.h"
 #include "device/geolocation/geoposition.h"
-#include "device/geolocation/location_arbitrator.h"
 #include "device/geolocation/location_provider.h"
 #include "net/url_request/url_request_context_getter.h"
 
 namespace net {
 class URLRequestContextGetter;
 }
 
 namespace device {
 class AccessTokenStore;
 class GeolocationDelegate;
 class LocationProvider;
 
 // This class is responsible for handling updates from multiple underlying
 // providers and resolving them to a single 'best' location fix at any given
 // moment.
 class DEVICE_GEOLOCATION_EXPORT LocationArbitratorImpl
-    : public LocationArbitrator {
+    : public LocationProvider {
  public:
   // Number of milliseconds newer a location provider has to be that it's worth
   // switching to this location provider on the basis of it being fresher
   // (regardles of relative accuracy). Public for tests.
   static const int64_t kFixStaleTimeoutMilliseconds;
 
   typedef base::Callback<void(const Geoposition&)> LocationUpdateCallback;
 
   LocationArbitratorImpl(const LocationUpdateCallback& callback,
                          GeolocationDelegate* delegate);
   ~LocationArbitratorImpl() override;
 
   static GURL DefaultNetworkProviderURL();
 
-  // LocationArbitrator
-  void StartProviders(bool enable_high_accuracy) override;
-  void StopProviders() override;
+  // LocationProvider

[Wez, 2016/08/09 01:17:04]

nit: "LocationProvider implementation."

[CJ, 2016/08/11 22:06:43]

Done.

+  void SetUpdateCallback(
+      const LocationProviderUpdateCallback& callback) override;
+  bool StartProvider(bool enable_high_accuracy) override;
+  void StopProvider() override;
+  void GetPosition(Geoposition* position) override;
+  void RequestRefresh() override;
   void OnPermissionGranted() override;
-  bool HasPermissionBeenGranted() const override;
+
+  bool HasPermissionBeenGranted() const;

[Wez, 2016/08/09 01:17:04]

Is this only used in tests, as discussed? If so then rename
HasPermissionBeenGrantedForTest() so that only test code can call it. :)

[CJ, 2016/08/11 22:06:43]

Done. Question, does adding "ForTest" to the end have an actual side effect, or
is just a guideline? 

[Wez, 2016/08/12 00:33:44]

IIRC there is a Clang plugin that will complain if you add code that calls
ForTest, but which is not in a _test.cc file, but yes, even without that, it's
good to be clear that this is not intended for production use. :)

 
  protected:
   // These functions are useful for injection of dependencies in derived
   // testing classes.
   virtual scoped_refptr<AccessTokenStore> NewAccessTokenStore();
   virtual std::unique_ptr<LocationProvider> NewNetworkLocationProvider(
       const scoped_refptr<AccessTokenStore>& access_token_store,
       const scoped_refptr<net::URLRequestContextGetter>& context,
       const GURL& url,
       const base::string16& access_token);
@@ skipping 52 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(LocationArbitratorImpl);
 };
 
 // Factory functions for the various types of location provider to abstract
 // over the platform-dependent implementations.
 std::unique_ptr<LocationProvider> NewSystemLocationProvider();
 
 }  // namespace device
 
 #endif  // DEVICE_GEOLOCATION_LOCATION_ARBITRATOR_IMPL_H_