Gets rid of the LocationArbitrator interface, in preference for LocationProvider.

device/geolocation/mock_location_provider.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DEVICE_GEOLOCATION_MOCK_LOCATION_PROVIDER_H_
 #define DEVICE_GEOLOCATION_MOCK_LOCATION_PROVIDER_H_
 
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/single_thread_task_runner.h"
 #include "base/threading/thread.h"
 #include "device/geolocation/geoposition.h"
 #include "device/geolocation/location_provider_base.h"
 
 namespace device {
 
 // Mock implementation of a location provider for testing.
 class MockLocationProvider : public LocationProviderBase {
  public:
   enum State { STOPPED, LOW_ACCURACY, HIGH_ACCURACY } state_;
 
   MockLocationProvider();
   ~MockLocationProvider() override;
 
+  bool providers_started() const { return state_ != STOPPED; }

[Kevin M, 2016/08/15 19:12:46]

This style of inline getter is only really allowed for just getting the value of
a field, not for computed results. This should be something like
IsProviderStarted().


nit: This is a LocationProvider (singular), but this getter is plural.

[CJ, 2016/08/15 20:11:51]

Done.

+
   // Updates listeners with the new position.
   void HandlePositionChanged(const Geoposition& position);
 
   // LocationProvider implementation.
   bool StartProvider(bool high_accuracy) override;
   void StopProvider() override;
   void GetPosition(Geoposition* position) override;
   void OnPermissionGranted() override;
 
   bool is_permission_granted_;
@@ skipping 18 matching lines @@
 // listeners with an error when StartProvider is called.
 LocationProvider* NewAutoFailMockLocationProvider();
 // Similar to NewAutoSuccessMockLocationProvider but mimicks the behavior of
 // the Network Location provider, in deferring making location updates until
 // a permission request has been confirmed.
 LocationProvider* NewAutoSuccessMockNetworkLocationProvider();
 
 }  // namespace device
 
 #endif  // DEVICE_GEOLOCATION_MOCK_LOCATION_PROVIDER_H_