Gets rid of the LocationArbitrator interface, in preference for LocationProvider.

device/geolocation/location_provider_base.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DEVICE_GEOLOCATION_LOCATION_PROVIDER_BASE_H_
 #define DEVICE_GEOLOCATION_LOCATION_PROVIDER_BASE_H_
 
 #include "base/macros.h"
 #include "device/geolocation/geolocation_export.h"
 #include "device/geolocation/location_provider.h"
 
 namespace device {
 
 class DEVICE_GEOLOCATION_EXPORT LocationProviderBase
     : NON_EXPORTED_BASE(public LocationProvider) {
  public:
   LocationProviderBase();
   ~LocationProviderBase() override;
 
  protected:
   void NotifyCallback(const Geoposition& position);
 
+  // Provides a hint to the provider that new location data is needed as soon
+  // as possible.
+  virtual void RequestRefresh();

[Wez, 2016/08/12 00:33:44]

Is there any point in keeping this at all?

Since it's no longer part of LocationProvider, just a protected method here,
nothing external can call it.

The only LocationProvider that does actually call it is the
NetworkLocationProvider - it's doing that internally, so there's no need for it
to be part of this base class - it can be a non-virtual in
NetworkLocationProvider itself.

[CJ, 2016/08/12 20:22:46]

Done.

+
   // Overridden from LocationProvider:
   void SetUpdateCallback(
       const LocationProviderUpdateCallback& callback) override;
-  void RequestRefresh() override;
 
  private:
   LocationProviderUpdateCallback callback_;
 
   DISALLOW_COPY_AND_ASSIGN(LocationProviderBase);
 };
 
 }  // namespace device
 
 #endif  // DEVICE_GEOLOCATION_LOCATION_PROVIDER_BASE_H_