views: Fix linux omnibox colors by refactoring omnibox_result_view.cc.

ui/native_theme/native_theme.h

Index: ui/native_theme/native_theme.h
diff --git a/ui/native_theme/native_theme.h b/ui/native_theme/native_theme.h
index aed39ada17faad0b4e4f5ebfe238596467a84d88..67af252d7bd849273056b306ab233ceddf78bcbb 100644
--- a/ui/native_theme/native_theme.h
+++ b/ui/native_theme/native_theme.h
@@ -281,6 +281,22 @@ class NATIVE_THEME_EXPORT NativeTheme {
     kColorId_TableSelectionBackgroundFocused,
     kColorId_TableSelectionBackgroundUnfocused,
     kColorId_TableGroupingIndicatorColor,
+    // Results Tables, such as the chrome omnibox.

[msw, 2014/04/03 18:53:53]

I think it would be beneficial to merge these colors with those used for Tables,
like the task manager's table view. I think the general table colors could use
the values you're adding for the omnibox result table. What do you and Scott
think about that?

It'd also be great to ditch [most of] the tree colors (used for the edit
bookmark dialog's tree view, etc.) and just use the corresponding table colors,
but that could be done separately.

[Elliot Glaysher, 2014/04/03 20:25:27]

This feels like a different control type. The omnibox is transient; clicking on
a result dismisses it, etc.

[sky, 2014/04/03 21:37:40]

I tend to favor explicit values, like Elliot has, and let the implementation
return the same values if it wants.

+    kColorId_ResultsTableNormalBackground,
+    kColorId_ResultsTableHoveredBackground,
+    kColorId_ResultsTableSelectedBackground,
+    kColorId_ResultsTableNormalText,
+    kColorId_ResultsTableHoveredText,
+    kColorId_ResultsTableSelectedText,
+    kColorId_ResultsTableNormalDimmedText,
+    kColorId_ResultsTableHoveredDimmedText,
+    kColorId_ResultsTableSelectedDimmedText,
+    kColorId_ResultsTableNormalUrl,
+    kColorId_ResultsTableHoveredUrl,
+    kColorId_ResultsTableSelectedUrl,
+    kColorId_ResultsTableNormalDivider,
+    kColorId_ResultsTableHoveredDivider,
+    kColorId_ResultsTableSelectedDivider,
     // TODO(benrg): move other hardcoded colors here.
   };