Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2226123003:
[LayoutNG] Add NGMarginStrut struct definition (Closed)
|
Created:
4 years, 4 months ago by Gleb Lanbin Modified:
4 years, 4 months ago CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, eae+blinkwatch, blink-reviews-layout_chromium.org, nasko+codewatch_chromium.org, jam, leviw+renderwatch, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, zoltan1, darin-cc_chromium.org, jchaffraix+rendering, blink-reviews, darin (slow to review), ben+mojo_chromium.org, szager+layoutwatch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[LayoutNG] Add NGMarginStrut struct definition
NOTRY=true
BUG=635619
Committed: https://crrev.com/63fb1399a8b1b1d9f73e663ea05d82ba08c08876
Cr-Commit-Position: refs/heads/master@{#410821}
Patch Set 1 : add NGMarginStrut #
Total comments: 2
Patch Set 2 : renamed fields #Patch Set 3 : renamed to marginBlock{start|end} #Patch Set 4 : merged to the head #Patch Set 5 : update core.gypi #
Messages
Total messages: 30 (19 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== add NGMarginStrut ========== to ========== NGMarginStrut struct definition ==========
glebl@chromium.org changed reviewers: + cbiesinger@chromium.org, eae@chromium.org
https://codereview.chromium.org/2226123003/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/layout/ng/NGMarginStrut.h (right): https://codereview.chromium.org/2226123003/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/layout/ng/NGMarginStrut.h:15: LayoutUnit marginBefore; CSS renamed this to margin-block-start/end: https://drafts.csswg.org/css-logical-props/#propdef-margin-block-start We should probably do the same. (It's also easier to understand that name, than to remember the difference between before/after and start/end)
Description was changed from ========== NGMarginStrut struct definition ========== to ========== [LayoutNG] Add NGMarginStrut struct definition ==========
LGTM following Christians suggestion
Description was changed from ========== [LayoutNG] Add NGMarginStrut struct definition ========== to ========== [LayoutNG] Add NGMarginStrut struct definition BUG=635619 ==========
https://codereview.chromium.org/2226123003/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/layout/ng/NGMarginStrut.h (right): https://codereview.chromium.org/2226123003/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/layout/ng/NGMarginStrut.h:15: LayoutUnit marginBefore; On 2016/08/09 17:33:55, cbiesinger wrote: > CSS renamed this to margin-block-start/end: > https://drafts.csswg.org/css-logical-props/#propdef-margin-block-start > > We should probably do the same. (It's also easier to understand that name, than > to remember the difference between before/after and start/end) Done.
The CQ bit was checked by glebl@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org Link to the patchset: https://codereview.chromium.org/2226123003/#ps40001 (title: "renamed fields")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by glebl@chromium.org
The CQ bit was checked by glebl@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org Link to the patchset: https://codereview.chromium.org/2226123003/#ps60001 (title: "renamed to marginBlock{start|end}")
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for third_party/WebKit/Source/core/core.gypi:
While running git apply --index -3 -p1;
error: patch failed: third_party/WebKit/Source/core/core.gypi:549
Falling back to three-way merge...
Applied patch to 'third_party/WebKit/Source/core/core.gypi' with conflicts.
U third_party/WebKit/Source/core/core.gypi
Patch: third_party/WebKit/Source/core/core.gypi
Index: third_party/WebKit/Source/core/core.gypi
diff --git a/third_party/WebKit/Source/core/core.gypi
b/third_party/WebKit/Source/core/core.gypi
index
ea144c17d18bdd98fa77d3a01195c80e7aaf375e..69ab35e6f566f331d42395135b32c5a5c43a891c
100644
--- a/third_party/WebKit/Source/core/core.gypi
+++ b/third_party/WebKit/Source/core/core.gypi
@@ -549,6 +549,7 @@
'layout/ng/NGConstraintSpace.h',
'layout/ng/NGFragment.cpp',
'layout/ng/NGFragment.h',
+ 'layout/ng/NGMarginStrut.h',
'layout/BidiRun.h',
'layout/BidiRunForLine.cpp',
'layout/BidiRunForLine.h',
Description was changed from ========== [LayoutNG] Add NGMarginStrut struct definition BUG=635619 ========== to ========== [LayoutNG] Add NGMarginStrut struct definition NOPRESUBMIT=true BUG=635619 ==========
The CQ bit was checked by glebl@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from cbiesinger@chromium.org, eae@chromium.org Link to the patchset: https://codereview.chromium.org/2226123003/#ps100001 (title: "update core.gypi")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [LayoutNG] Add NGMarginStrut struct definition NOPRESUBMIT=true BUG=635619 ========== to ========== [LayoutNG] Add NGMarginStrut struct definition NOTRY=true BUG=635619 ==========
The CQ bit was unchecked by glebl@chromium.org
The CQ bit was checked by glebl@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [LayoutNG] Add NGMarginStrut struct definition NOTRY=true BUG=635619 ========== to ========== [LayoutNG] Add NGMarginStrut struct definition NOTRY=true BUG=635619 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== [LayoutNG] Add NGMarginStrut struct definition NOTRY=true BUG=635619 ========== to ========== [LayoutNG] Add NGMarginStrut struct definition NOTRY=true BUG=635619 Committed: https://crrev.com/63fb1399a8b1b1d9f73e663ea05d82ba08c08876 Cr-Commit-Position: refs/heads/master@{#410821} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/63fb1399a8b1b1d9f73e663ea05d82ba08c08876 Cr-Commit-Position: refs/heads/master@{#410821} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
