Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2226123002: Android: add screen share icon for permission infobar (Closed)

Created:
4 years, 4 months ago by braveyao
Modified:
4 years, 4 months ago
Reviewers:
oshima, gone
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: add screen share icon for permission infobar This is to add new screen share icon for the upcoming screen capture feature in chrome on Android(in cl https://codereview.chromium.org/2123863004/). The permission infobar with this screen share icon will be promoted each time when screen sharing is requested. BUG=487935 Committed: https://crrev.com/92b46bda640a3bd8f1639778309458e852d84df6 Cr-Commit-Position: refs/heads/master@{#410741}

Patch Set 1 #

Messages

Total messages: 21 (11 generated)
braveyao
Hi Ted, please have a look at this cl!
4 years, 4 months ago (2016-08-08 23:25:10 UTC) #6
braveyao
Hi Dan, please help to take a look at this cl.
4 years, 4 months ago (2016-08-08 23:36:03 UTC) #8
gone
lgtm
4 years, 4 months ago (2016-08-08 23:45:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226123002/1
4 years, 4 months ago (2016-08-08 23:50:39 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/233328)
4 years, 4 months ago (2016-08-08 23:57:37 UTC) #13
braveyao
Hi oshima@, please help to take a look to chrome/app/theme/.
4 years, 4 months ago (2016-08-09 00:01:13 UTC) #15
oshima
lgtm
4 years, 4 months ago (2016-08-09 18:01:11 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226123002/1
4 years, 4 months ago (2016-08-09 18:02:50 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 18:08:05 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 18:10:35 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92b46bda640a3bd8f1639778309458e852d84df6
Cr-Commit-Position: refs/heads/master@{#410741}

Powered by Google App Engine
This is Rietveld 408576698