Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2226113002: Add CPDF_Array::IsEmpty(). (Closed)

Created:
4 years, 4 months ago by jaepark
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Add CPDF_Array::IsEmpty(). Using IsEmpty() is more readable than using GetCount() == 0. Committed: https://pdfium.googlesource.com/pdfium/+/727da4f329956406b936ba9c0bc49ab2d32db67e

Patch Set 1 : Add CPDF_Array::IsEmpty(). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M core/fpdfapi/fpdf_page/cpdf_colorspace.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_doc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/include/cpdf_array.h View 1 chunk +1 line, -0 lines 0 comments Download
M core/fpdfdoc/cpdf_formfield.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
jaepark
4 years, 4 months ago (2016-08-08 22:33:46 UTC) #7
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-08 22:39:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226113002/20001
4 years, 4 months ago (2016-08-08 22:45:43 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 22:46:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/727da4f329956406b936ba9c0bc49ab2d32d...

Powered by Google App Engine
This is Rietveld 408576698