Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2226093002: Record information about a summary's dependencies in the summary itself. (Closed)

Created:
4 years, 4 months ago by Paul Berry
Modified:
4 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Record information about a summary's dependencies in the summary itself. The idea is that we can use this information to help discover related summary files, and determine when summaries need to be re-linked. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/902ce5e7390e5aca186ad8b7c89c7206d8fcce6c

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+470 lines, -16 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 12 chunks +236 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/format.fbs View 2 chunks +45 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 2 chunks +52 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/package_bundle_reader.dart View 4 chunks +43 lines, -1 line 2 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 4 chunks +13 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/linker_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/package_bundle_reader_test.dart View 4 chunks +55 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/summarize_ast_test.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/analyzer_cli/lib/src/build_mode.dart View 4 chunks +20 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 4 months ago (2016-08-08 21:58:35 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2226093002/diff/1/pkg/analyzer/lib/src/summary/package_bundle_reader.dart File pkg/analyzer/lib/src/summary/package_bundle_reader.dart (right): https://codereview.chromium.org/2226093002/diff/1/pkg/analyzer/lib/src/summary/package_bundle_reader.dart#newcode278 pkg/analyzer/lib/src/summary/package_bundle_reader.dart:278: * [SummaryDataStore], in a form that is ready ...
4 years, 4 months ago (2016-08-09 02:39:44 UTC) #3
Paul Berry
https://codereview.chromium.org/2226093002/diff/1/pkg/analyzer/lib/src/summary/package_bundle_reader.dart File pkg/analyzer/lib/src/summary/package_bundle_reader.dart (right): https://codereview.chromium.org/2226093002/diff/1/pkg/analyzer/lib/src/summary/package_bundle_reader.dart#newcode278 pkg/analyzer/lib/src/summary/package_bundle_reader.dart:278: * [SummaryDataStore], in a form that is ready to ...
4 years, 4 months ago (2016-08-09 16:30:30 UTC) #4
Paul Berry
4 years, 4 months ago (2016-08-09 16:31:11 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
902ce5e7390e5aca186ad8b7c89c7206d8fcce6c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698