Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: components/translate/core/browser/translate_ui_delegate_unittest.cc

Issue 2226063002: Add a ScopedFeatureList class for testing and start using it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix issue in previous patchset. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_ui_delegate_unittest.cc
diff --git a/components/translate/core/browser/translate_ui_delegate_unittest.cc b/components/translate/core/browser/translate_ui_delegate_unittest.cc
index 415f67d7ba18486a3d97263a121c1eb9040dfbef..a24b88eac4ebaa62c87a3766ad0bb37058c7b7ac 100644
--- a/components/translate/core/browser/translate_ui_delegate_unittest.cc
+++ b/components/translate/core/browser/translate_ui_delegate_unittest.cc
@@ -9,6 +9,7 @@
#include "base/macros.h"
#include "base/memory/ptr_util.h"
#include "base/strings/stringprintf.h"
+#include "base/test/scoped_feature_list.h"
#include "build/build_config.h"
#include "components/infobars/core/infobar.h"
#include "components/pref_registry/pref_registry_syncable.h"
@@ -93,16 +94,10 @@ class TranslateUIDelegateTest : public ::testing::Test {
new TranslateUIDelegate(manager_->GetWeakPtr(), "ar", "fr"));
ASSERT_FALSE(client_->GetTranslatePrefs()->IsTooOftenDenied("ar"));
- base::FeatureList::ClearInstanceForTesting();
- base::FeatureList::SetInstance(base::WrapUnique(new base::FeatureList));
}
void TurnOnTranslate2016Q2UIFlag() {
- base::FeatureList::ClearInstanceForTesting();
- std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);
- feature_list->InitializeFromCommandLine(translate::kTranslateUI2016Q2.name,
- std::string());
- base::FeatureList::SetInstance(std::move(feature_list));
+ scoped_feature_list_.InitAndEnableFeature(translate::kTranslateUI2016Q2);
}
MockTranslateDriver driver_;
@@ -110,6 +105,7 @@ class TranslateUIDelegateTest : public ::testing::Test {
std::unique_ptr<user_prefs::TestingPrefServiceSyncable> pref_service_;
std::unique_ptr<TranslateManager> manager_;
std::unique_ptr<TranslateUIDelegate> delegate_;
+ base::test::ScopedFeatureList scoped_feature_list_;
private:
DISALLOW_COPY_AND_ASSIGN(TranslateUIDelegateTest);

Powered by Google App Engine
This is Rietveld 408576698