Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11048)

Unified Diff: components/subresource_filter/core/browser/subresource_filter_features_test_support.cc

Issue 2226063002: Add a ScopedFeatureList class for testing and start using it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix issue in previous patchset. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/core/browser/subresource_filter_features_test_support.cc
diff --git a/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc b/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc
index 87dd1a0b8c39ce3f53c5a59680b1ac03c8e1473b..997732630691b77f01a1b0193260f5ca3307ea89 100644
--- a/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc
+++ b/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc
@@ -24,7 +24,6 @@ ScopedSubresourceFilterFeatureToggle::ScopedSubresourceFilterFeatureToggle(
base::FeatureList::OverrideState feature_state,
const std::string& maximum_activation_state,
const std::string& activation_scope) {
- base::FeatureList::ClearInstanceForTesting();
variations::testing::ClearAllVariationParams();
std::map<std::string, std::string> variation_params;
@@ -39,12 +38,11 @@ ScopedSubresourceFilterFeatureToggle::ScopedSubresourceFilterFeatureToggle(
std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);
feature_list->RegisterFieldTrialOverride(kSafeBrowsingSubresourceFilter.name,
feature_state, field_trial);
- base::FeatureList::SetInstance(std::move(feature_list));
+ scoped_feature_list_.InitWithFeatureList(std::move(feature_list));
}
ScopedSubresourceFilterFeatureToggle::~ScopedSubresourceFilterFeatureToggle() {
variations::testing::ClearAllVariationParams();
- base::FeatureList::ClearInstanceForTesting();
}
} // namespace testing

Powered by Google App Engine
This is Rietveld 408576698