Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: components/translate/core/browser/translate_prefs_unittest.cc

Issue 2226063002: Add a ScopedFeatureList class for testing and start using it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix issue in previous patchset. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/translate/core/browser/translate_prefs.h" 5 #include "components/translate/core/browser/translate_prefs.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
11 11
12 #include "base/test/scoped_feature_list.h"
12 #include "build/build_config.h" 13 #include "build/build_config.h"
13 #include "components/pref_registry/testing_pref_service_syncable.h" 14 #include "components/pref_registry/testing_pref_service_syncable.h"
14 #include "components/prefs/scoped_user_pref_update.h" 15 #include "components/prefs/scoped_user_pref_update.h"
15 #include "components/translate/core/browser/translate_download_manager.h" 16 #include "components/translate/core/browser/translate_download_manager.h"
16 #include "components/translate/core/browser/translate_prefs.h" 17 #include "components/translate/core/browser/translate_prefs.h"
17 #include "testing/gtest/include/gtest/gtest.h" 18 #include "testing/gtest/include/gtest/gtest.h"
18 19
19 namespace { 20 namespace {
20 21
21 const char kTestLanguage[] = "en"; 22 const char kTestLanguage[] = "en";
(...skipping 21 matching lines...) Expand all
43 void SetLastDeniedTime(const std::string& language, base::Time time) { 44 void SetLastDeniedTime(const std::string& language, base::Time time) {
44 DenialTimeUpdate update(prefs_.get(), language, 2); 45 DenialTimeUpdate update(prefs_.get(), language, 2);
45 update.AddDenialTime(time); 46 update.AddDenialTime(time);
46 } 47 }
47 48
48 base::Time GetLastDeniedTime(const std::string& language) { 49 base::Time GetLastDeniedTime(const std::string& language) {
49 DenialTimeUpdate update(prefs_.get(), language, 2); 50 DenialTimeUpdate update(prefs_.get(), language, 2);
50 return update.GetOldestDenialTime(); 51 return update.GetOldestDenialTime();
51 } 52 }
52 53
53 void SetUp() override { 54 void TurnOnTranslate2016Q2UIFlag() {
54 base::FeatureList::ClearInstanceForTesting(); 55 scoped_feature_list_.InitAndEnableFeature(translate::kTranslateUI2016Q2);
55 base::FeatureList::SetInstance(base::WrapUnique(new base::FeatureList()));
56 } 56 }
57 57
58 void TurnOnTranslate2016Q2UIFlag() { 58 base::test::ScopedFeatureList scoped_feature_list_;
59 base::FeatureList::ClearInstanceForTesting();
60 std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);
61 feature_list->InitializeFromCommandLine(translate::kTranslateUI2016Q2.name,
62 std::string());
63 base::FeatureList::SetInstance(std::move(feature_list));
64 }
65
66 std::unique_ptr<user_prefs::TestingPrefServiceSyncable> prefs_; 59 std::unique_ptr<user_prefs::TestingPrefServiceSyncable> prefs_;
67 std::unique_ptr<translate::TranslatePrefs> translate_prefs_; 60 std::unique_ptr<translate::TranslatePrefs> translate_prefs_;
68 61
69 // Shared time constants. 62 // Shared time constants.
70 base::Time now_; 63 base::Time now_;
71 base::Time two_days_ago_; 64 base::Time two_days_ago_;
72 }; 65 };
73 66
74 TEST_F(TranslatePrefTest, IsTooOftenDeniedIn2016Q2UI) { 67 TEST_F(TranslatePrefTest, IsTooOftenDeniedIn2016Q2UI) {
75 TurnOnTranslate2016Q2UIFlag(); 68 TurnOnTranslate2016Q2UIFlag();
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 update.AddDenialTime(now_); 206 update.AddDenialTime(now_);
214 EXPECT_EQ(update.GetOldestDenialTime(), 207 EXPECT_EQ(update.GetOldestDenialTime(),
215 now_ - base::TimeDelta::FromMinutes(3)); 208 now_ - base::TimeDelta::FromMinutes(3));
216 209
217 update.AddDenialTime(now_); 210 update.AddDenialTime(now_);
218 EXPECT_EQ(update.GetOldestDenialTime(), 211 EXPECT_EQ(update.GetOldestDenialTime(),
219 now_ - base::TimeDelta::FromMinutes(2)); 212 now_ - base::TimeDelta::FromMinutes(2));
220 } 213 }
221 214
222 } // namespace translate 215 } // namespace translate
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698