Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2226033002: Use LayoutNGBlockFlow for the block layout if layoutNG is enabled. (Closed)

Created:
4 years, 4 months ago by Gleb Lanbin
Modified:
4 years, 4 months ago
Reviewers:
cbiesinger, ikilpatrick
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use LayoutNGBlockFlow for the block layout if layoutNG is enabled. BUG=635619 Committed: https://crrev.com/756f6b3cbb4af8b77421d8fea3fa22d07d4c6996 Cr-Commit-Position: refs/heads/master@{#410587}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 30 (14 generated)
Gleb Lanbin
4 years, 4 months ago (2016-08-08 20:18:35 UTC) #2
cbiesinger
lgtm
4 years, 4 months ago (2016-08-08 20:40:59 UTC) #4
ikilpatrick
lgtm
4 years, 4 months ago (2016-08-08 20:42:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226033002/20001
4 years, 4 months ago (2016-08-09 01:01:13 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/179984) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 4 months ago (2016-08-09 01:09:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226033002/20001
4 years, 4 months ago (2016-08-09 01:10:28 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/203899)
4 years, 4 months ago (2016-08-09 01:16:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226033002/20001
4 years, 4 months ago (2016-08-09 01:19:40 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/203919)
4 years, 4 months ago (2016-08-09 01:24:11 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226033002/20001
4 years, 4 months ago (2016-08-09 01:28:07 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/180007) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 4 months ago (2016-08-09 01:35:43 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226033002/20001
4 years, 4 months ago (2016-08-09 02:20:04 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/269471)
4 years, 4 months ago (2016-08-09 03:22:08 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226033002/20001
4 years, 4 months ago (2016-08-09 03:47:29 UTC) #27
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 4 months ago (2016-08-09 05:35:19 UTC) #28
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 05:38:27 UTC) #30
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/756f6b3cbb4af8b77421d8fea3fa22d07d4c6996
Cr-Commit-Position: refs/heads/master@{#410587}

Powered by Google App Engine
This is Rietveld 408576698