Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2226023005: [heap] Use size-based live object iterator. (Closed)

Created:
4 years, 4 months ago by Hannes Payer (out of office)
Modified:
4 years, 4 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Use size-based live object iterator. BUG=chromium:634900 Committed: https://crrev.com/6380c31a5cacd9a8765a3d0ef0189e35fe01df4c Cr-Commit-Position: refs/heads/master@{#38481}

Patch Set 1 #

Patch Set 2 : Revert "[heap] Temporarily use old live object iterator to investigate Win 10 memory regression." #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -10 lines) Patch
M src/heap/mark-compact-inl.h View 1 chunk +51 lines, -10 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +158 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Michael Lippautz
lgtm
4 years, 4 months ago (2016-08-09 09:56:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226023005/20001
4 years, 4 months ago (2016-08-09 10:48:35 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-09 10:50:33 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 10:50:48 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6380c31a5cacd9a8765a3d0ef0189e35fe01df4c
Cr-Commit-Position: refs/heads/master@{#38481}

Powered by Google App Engine
This is Rietveld 408576698