content/browser/renderer_host/render_view_host_impl.cc - Issue 2226023003: Fix RenderView reuse issues after a pending RenderFrameHost dies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 2226023003: Fix RenderView reuse issues after a pending RenderFrameHost dies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback from creis@ and nasko@ Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/render_view_host_impl.cc

diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc

index f993e0a524e2c81679eaf12709b2457666018a24..a3a1a6a451a8dc8b2b58a9d102c19fe709d4d466 100644

--- a/content/browser/renderer_host/render_view_host_impl.cc

+++ b/content/browser/renderer_host/render_view_host_impl.cc

@@ -325,7 +325,7 @@ bool RenderViewHostImpl::CreateRenderView(

// We should not set both main_frame_routing_id_ and proxy_route_id. Log

// cases that this happens (without crashing) to track down

- // https://crbug.com/574245.

+ // https://crbug.com/575245.

// TODO(creis): Remove this once we've found the cause.

if (main_frame_routing_id_ != MSG_ROUTING_NONE &&

proxy_route_id != MSG_ROUTING_NONE)

« no previous file with comments | « content/browser/frame_host/render_frame_host_manager.cc ('k') | content/browser/site_per_process_browsertest.cc » ('j') | no next file with comments »