Fixup various overflow conditions

Fixup various overflow conditions

There were several overflows detected by the PDF from the linked bug. This
Cl fixes up the base causes of each of them.

BUG=chromium:635473
Committed: https://pdfium.googlesource.com/pdfium/+/fb362089d952950212ccf159f86a46923f223172

[dsinclair, 2016-08-08 19:38:17]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 19:38:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-08-08 19:38:36]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-08-08 19:38:37]

PTAL.

[commit-bot: I haz the power, 2016-08-08 19:42:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 19:42:13]

Dry run: Try jobs failed on following builders:
  linux_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa/build...)

[dsinclair, 2016-08-08 19:45:49]

Seem to have broken corpus tests. Ignore while I investigate. Will ping again
....

[dsinclair, 2016-08-08 20:37:50]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 20:37:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-08-08 20:48:54]

PTAL. I removed one of the AGG changes. It seems to cause issues with fills
either not working, or the alpha channel being different if it's included. In
theory it should go away once we have Skia anyway.

[commit-bot: I haz the power, 2016-08-08 20:54:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 20:54:27]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-08-08 21:09:45]

lgtm

https://codereview.chromium.org/2226023002/diff/20001/core/fxcrt/include/fx_c...
File core/fxcrt/include/fx_coordinates.h (right):

https://codereview.chromium.org/2226023002/diff/20001/core/fxcrt/include/fx_c...
core/fxcrt/include/fx_coordinates.h:154: pdfium::base::CheckedNumeric<int> w =
right;
nit: I might write this as

pdfium::base::CheckedNumeric<int> w = right;
pdfium::base::CheckedNumeric<int> h = bottom;
w -= left;
h -= top;
return w.IsValid() && h.IsValid();

No sense optimizing for the invalid case.

[dsinclair, 2016-08-09 13:35:19]

https://codereview.chromium.org/2226023002/diff/20001/core/fxcrt/include/fx_c...
File core/fxcrt/include/fx_coordinates.h (right):

https://codereview.chromium.org/2226023002/diff/20001/core/fxcrt/include/fx_c...
core/fxcrt/include/fx_coordinates.h:154: pdfium::base::CheckedNumeric<int> w =
right;
On 2016/08/08 21:09:45, Tom Sepez wrote:
> nit: I might write this as
> 
> pdfium::base::CheckedNumeric<int> w = right;
> pdfium::base::CheckedNumeric<int> h = bottom;
> w -= left;
> h -= top;
> return w.IsValid() && h.IsValid();
> 
> No sense optimizing for the invalid case.

Done.

[dsinclair, 2016-08-09 13:35:32]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-08-09 13:35:32]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2226023002/#ps40001
(title: "Review cleanup")

[commit-bot: I haz the power, 2016-08-09 13:35:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 13:50:33]

Description was changed from

==========
Fixup various overflow conditions

There were several overflows detected by the PDF from the linked bug. This
Cl fixes up the base causes of each of them.

BUG=chromium:635473
==========

to

==========
Fixup various overflow conditions

There were several overflows detected by the PDF from the linked bug. This
Cl fixes up the base causes of each of them.

BUG=chromium:635473

Committed:
https://pdfium.googlesource.com/pdfium/+/fb362089d952950212ccf159f86a46923f22...
==========

[commit-bot: I haz the power, 2016-08-09 13:50:35]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/fb362089d952950212ccf159f86a46923f22...