Settings Router Refactor: Remove subpage-back.

chrome/browser/resources/settings/site_settings/site_details.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'site-details' show the details (permissions and usage) for a given origin
  * under Site Settings.
  */
 Polymer({
@@ skipping 71 matching lines @@
       this.onClearStorage_();
     else
       this.navigateBackIfNoData_();
   },
 
   /**
    * Navigate back if the UI is empty (everything been cleared).
    */
   navigateBackIfNoData_: function() {
     if (this.storedData_ == '' && !this.permissionShowing_())
-      this.fire('subpage-back');
+      settings.navigateTo(settings.Route.SITE_SETTINGS_ALL);

[Finnur, 2016/08/23 13:04:17]

Hmmm... This is a bit problematic... :/

When you open some category, then enter Site Details and click 'Clear and
Reset', the page should navigate back to the category you used to get to the
Site Details page. Instead it goes to the All Sites page, which is weird.

See first video in this bug:
http://crbug.com/639208

[tommycli, 2016/08/23 16:35:28]

Try changing it to settings.navigateToPreviousRoute(). Does that fix it?

   },
 
   /**
    * Returns true if one or more permission is showing.
    */
   permissionShowing_: function() {
     return Array.prototype.some.call(
         this.root.querySelectorAll('site-details-permission'),
         function(element) { return element.offsetHeight > 0; });
   },
 });