Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: chrome/browser/resources/settings/internet_page/internet_detail_page.js

Issue 2226003002: Settings Router Refactor: Remove subpage-back. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-internet-detail' is the settings subpage containing details 7 * 'settings-internet-detail' is the settings subpage containing details
8 * for a network. 8 * for a network.
9 */ 9 */
10 (function() { 10 (function() {
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 }, 120 },
121 121
122 /** @override */ 122 /** @override */
123 detached: function() { 123 detached: function() {
124 this.networkingPrivate.onNetworksChanged.removeListener( 124 this.networkingPrivate.onNetworksChanged.removeListener(
125 this.networksChangedListener_); 125 this.networksChangedListener_);
126 }, 126 },
127 127
128 /** @private */ 128 /** @private */
129 close_: function() { 129 close_: function() {
130 // Delay sending subpage-back until the next render frame to allow other 130 // Delay navigating until the next render frame to allow other subpages to
131 // subpages to load first. 131 // load first.
132 setTimeout(function() { 132 setTimeout(function() { settings.navigateTo(settings.Route.INTERNET) });
133 this.fire('subpage-back');
134 }.bind(this));
135 }, 133 },
136 134
137 /** @private */ 135 /** @private */
138 guidChanged_: function() { 136 guidChanged_: function() {
139 if (!this.guid) 137 if (!this.guid)
140 this.close_(); 138 this.close_();
141 this.getNetworkDetails_(); 139 this.getNetworkDetails_();
142 }, 140 },
143 141
144 /** @private */ 142 /** @private */
(...skipping 606 matching lines...) Expand 10 before | Expand all | Expand 10 after
751 */ 749 */
752 allPropertiesMatch_: function(curValue, newValue) { 750 allPropertiesMatch_: function(curValue, newValue) {
753 for (let key in newValue) { 751 for (let key in newValue) {
754 if (newValue[key] != curValue[key]) 752 if (newValue[key] != curValue[key])
755 return false; 753 return false;
756 } 754 }
757 return true; 755 return true;
758 } 756 }
759 }); 757 });
760 })(); 758 })();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698