Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2225983002: Suppress ValidFragment warning for non default fragment constructor. (Closed)

Created:
4 years, 4 months ago by estevenson
Modified:
4 years, 4 months ago
Reviewers:
aberent
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress ValidFragment warning for non default fragment constructor. The non default constructor was added for https://crbug.com/618993. BUG=635567 Committed: https://crrev.com/f84bc5b28466ff39c7b34320d357a430bb1e6631 Cr-Commit-Position: refs/heads/master@{#410666}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/MediaRouteChooserDialogFactory.java View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
estevenson
ptal, trying to clean up lint warnings!
4 years, 4 months ago (2016-08-08 17:43:46 UTC) #2
aberent
lgtm
4 years, 4 months ago (2016-08-09 09:36:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225983002/1
4 years, 4 months ago (2016-08-09 13:35:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 14:39:02 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 14:41:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f84bc5b28466ff39c7b34320d357a430bb1e6631
Cr-Commit-Position: refs/heads/master@{#410666}

Powered by Google App Engine
This is Rietveld 408576698