Strip more unused features.

Strip more unused features.


Switch to the more limited scope task of creating JS Interop Facades allowing export of TypeScript APIs to Dart from of the far more difficult task of compiling TypeScript code to Dart code.

BUG=
R=kevmoo@google.com

Committed: https://github.com/dart-lang/linter/commit/74b08179d193c19c112accf60b9cbf8e7625bdb6

[Jacob, 2016-08-08 17:24:55]

jacobr@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2016-08-08 17:28:05]

https://codereview.chromium.org/2225953002/diff/1/README.md
File README.md (left):

https://codereview.chromium.org/2225953002/diff/1/README.md#oldcode1
README.md:1: # TypeScript to Dart transpiler [![Build
Status](https://travis-ci.org/angular/ts2dart.svg?branch=master)](https://travis-ci.org/angular/ts2dart)
Need to discuss how to actually install and use *this* tool – not just how to
get the repo running

Need to publish to NPM, etc

https://codereview.chromium.org/2225953002/diff/1/package.json
File package.json (right):

https://codereview.chromium.org/2225953002/diff/1/package.json#newcode49
package.json:49: "Jacob Richman <jacobr@google.com>
(https://www.dartlang.org/)",
remove trailing comma

https://codereview.chromium.org/2225953002/diff/1/package.json#newcode49
package.json:49: "Jacob Richman <jacobr@google.com>
(https://www.dartlang.org/)",
Also: should we just have this be "Dart project authors" or something?

[kevmoo, 2016-08-08 17:36:41]

lgtm

[kevmoo, 2016-08-17 19:03:52]

On 2016/08/08 17:36:41, kevmoo wrote:
> lgtm

What's our story here?

[Jacob, 2016-08-29 21:01:15]

Uploaded updated version.
The impact of the fixes can be seen in the test expectation delta. Cleaned up
how type comments were specified so we stopped using /*= syntax for comments
that aren't yet valid Dart types. This required a bit more refactoring than I'd
like.
Also added a very basic usage example.
Still need to get a working true e2e test using a d.ts library added as part of
the code base.

[kevmoo, 2016-08-29 21:36:32]

On 2016/08/29 21:01:15, Jacob wrote:
> Uploaded updated version.
> The impact of the fixes can be seen in the test expectation delta. Cleaned up
> how type comments were specified so we stopped using /*= syntax for comments
> that aren't yet valid Dart types. This required a bit more refactoring than
I'd
> like.
> Also added a very basic usage example.
> Still need to get a working true e2e test using a d.ts library added as part
of
> the code base.

Get on warning when running `gulp test`

[14:34:18] WARNING: Files are not properly formatted. Please run
[14:34:18]   node_modules/clang-format/index.js -i -style="file"
/Users/kevmoo/source/github/js_facade_gen/test/facade_converter_test.ts
[14:34:18]   (using clang-format version 1.0.43)
[14:34:18] files not formatted


Also: where can I see/create dart files?

[Jacob, 2016-08-29 21:44:27]

On 2016/08/29 21:36:32, kevmoo wrote:
> On 2016/08/29 21:01:15, Jacob wrote:
> > Uploaded updated version.
> > The impact of the fixes can be seen in the test expectation delta. Cleaned
up
> > how type comments were specified so we stopped using /*= syntax for comments
> > that aren't yet valid Dart types. This required a bit more refactoring than
> I'd
> > like.
> > Also added a very basic usage example.
> > Still need to get a working true e2e test using a d.ts library added as part
> of
> > the code base.
> 
> Get on warning when running `gulp test`
> 
> [14:34:18] WARNING: Files are not properly formatted. Please run
> [14:34:18]   node_modules/clang-format/index.js -i -style="file"
> /Users/kevmoo/source/github/js_facade_gen/test/facade_converter_test.ts
> [14:34:18]   (using clang-format version 1.0.43)
> [14:34:18] files not formatted
> 
> 
> Also: where can I see/create dart files?
Where to run:
See README.md
Here is how you can create dart files:
node build/lib/main.js --destination=<destination-dir> <input d.ts filename>

Just ran gulp test again and didn't see any format errors. I have clang-format
NPM version 1.0.42
what do you see when you run
node_modules/clang-format/index.js --version

[kevmoo, 2016-08-29 22:21:41]

On 2016/08/29 21:36:32, kevmoo wrote:
> On 2016/08/29 21:01:15, Jacob wrote:
> > Uploaded updated version.
> > The impact of the fixes can be seen in the test expectation delta. Cleaned
up
> > how type comments were specified so we stopped using /*= syntax for comments
> > that aren't yet valid Dart types. This required a bit more refactoring than
> I'd
> > like.
> > Also added a very basic usage example.
> > Still need to get a working true e2e test using a d.ts library added as part
> of
> > the code base.
> 
> Get on warning when running `gulp test`
> 
> [14:34:18] WARNING: Files are not properly formatted. Please run
> [14:34:18]   node_modules/clang-format/index.js -i -style="file"
> /Users/kevmoo/source/github/js_facade_gen/test/facade_converter_test.ts
> [14:34:18]   (using clang-format version 1.0.43)
> [14:34:18] files not formatted
> 
> 
> Also: where can I see/create dart files?

Missing import of required 'dart:html'

Also having a lot of issues with --destination – really weird

I have other issues with runtime behavior – but we can talk about that

[kevmoo, 2016-08-29 22:23:04]

On 2016/08/29 21:44:27, Jacob wrote:
> On 2016/08/29 21:36:32, kevmoo wrote:
> > On 2016/08/29 21:01:15, Jacob wrote:
> > > Uploaded updated version.
> > > The impact of the fixes can be seen in the test expectation delta. Cleaned
> up
> > > how type comments were specified so we stopped using /*= syntax for
comments
> > > that aren't yet valid Dart types. This required a bit more refactoring
than
> > I'd
> > > like.
> > > Also added a very basic usage example.
> > > Still need to get a working true e2e test using a d.ts library added as
part
> > of
> > > the code base.
> > 
> > Get on warning when running `gulp test`
> > 
> > [14:34:18] WARNING: Files are not properly formatted. Please run
> > [14:34:18]   node_modules/clang-format/index.js -i -style="file"
> > /Users/kevmoo/source/github/js_facade_gen/test/facade_converter_test.ts
> > [14:34:18]   (using clang-format version 1.0.43)
> > [14:34:18] files not formatted
> > 
> > 
> > Also: where can I see/create dart files?
> Where to run:
> See README.md
> Here is how you can create dart files:
> node build/lib/main.js --destination=<destination-dir> <input d.ts filename>
> 
> Just ran gulp test again and didn't see any format errors. I have clang-format
> NPM version 1.0.42

I have 1.0.43 – try 'npm install' again and double check?

> what do you see when you run
> node_modules/clang-format/index.js --version

[Jacob, 2016-08-29 23:31:13]

Description was changed from

==========
Strip more unused features.


Switch to the more limited scope task of creating JS Interop Facades allowing
export of TypeScript APIs to Dart from of the far more difficult task of
compiling TypeScript code to Dart code.

BUG=
==========

to

==========
Strip more unused features.


Switch to the more limited scope task of creating JS Interop Facades allowing
export of TypeScript APIs to Dart from of the far more difficult task of
compiling TypeScript code to Dart code.

BUG=
R=kevmoo@google.com

Committed:
https://github.com/dart-lang/linter/commit/74b08179d193c19c112accf60b9cbf8e76...
==========

[Jacob, 2016-08-29 23:31:14]

Committed patchset #3 (id:40001) manually as
74b08179d193c19c112accf60b9cbf8e7625bdb6 (presubmit successful).