[ios] Purge web view if external app URL is current in navigation stack.

[ios] Purge web view if external app URL is current in navigation stack.

BUG=634954
Committed: https://crrev.com/d16b2b5b97c2544d8e6d18870eb0caebe8b5c4ac
Cr-Commit-Position: refs/heads/master@{#410492}

[Eugene But (OOO till 7-30), 2016-08-08 17:08:08]

eugenebut@chromium.org changed reviewers:
+ jyquinn@chromium.org

[Eugene But (OOO till 7-30), 2016-08-08 17:08:08]

Please see bug for details.

[Jackie Quinn, 2016-08-08 21:30:10]

lgtm with comment nit and task list suggestion.

https://codereview.chromium.org/2225943002/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/2225943002/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.mm:3346: // Purge web view in case if
last committed URL is different from the
You could remove "in case"

https://codereview.chromium.org/2225943002/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.mm:3354: _documentURL =
lastCommittedURL;
Is this something that generally needs to be done when there's a page
reconstruction? 

It looks like the header comments for requirePageReconstruction and friends are
littered with TODO(stuartmorgan): Clean up and consolidate. Is this on the web
tasks list? If not it probably should be?

[Eugene But (OOO till 7-30), 2016-08-08 21:47:32]

Thanks!

https://codereview.chromium.org/2225943002/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/2225943002/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.mm:3346: // Purge web view in case if
last committed URL is different from the
On 2016/08/08 21:30:09, Jackie Quinn wrote:
> You could remove "in case"

Done.

https://codereview.chromium.org/2225943002/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.mm:3354: _documentURL =
lastCommittedURL;
On 2016/08/08 21:30:09, Jackie Quinn wrote:
> Is this something that generally needs to be done when there's a page
> reconstruction? 
No, it's a special case where _documentURL does not represent the reality but it
should.
 
> It looks like the header comments for requirePageReconstruction and friends
are
> littered with TODO(stuartmorgan): Clean up and consolidate. Is this on the web
> tasks list? If not it probably should be?
Yes, we have a list of various refactoring we need to do in web controller.

[Eugene But (OOO till 7-30), 2016-08-08 22:40:05]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-08-08 22:40:06]

The patchset sent to the CQ was uploaded after l-g-t-m from jyquinn@chromium.org
Link to the patchset: https://codereview.chromium.org/2225943002/#ps20001
(title: "Addressed review comments")

[commit-bot: I haz the power, 2016-08-08 22:40:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 23:21:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-08 23:24:03]

Description was changed from

==========
[ios] Purge web view if external app URL is current in navigation stack.

BUG=634954
==========

to

==========
[ios] Purge web view if external app URL is current in navigation stack.

BUG=634954

Committed: https://crrev.com/d16b2b5b97c2544d8e6d18870eb0caebe8b5c4ac
Cr-Commit-Position: refs/heads/master@{#410492}
==========

[commit-bot: I haz the power, 2016-08-08 23:24:04]

Patchset 2 (id:??) landed as
https://crrev.com/d16b2b5b97c2544d8e6d18870eb0caebe8b5c4ac
Cr-Commit-Position: refs/heads/master@{#410492}