Avoid adding invalid headers in AddHeaderFromString

net/http/http_request_headers.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // HttpRequestHeaders manages the request headers.
 // It maintains these in a vector of header key/value pairs, thereby maintaining
 // the order of the headers.  This means that any lookups are linear time
 // operations.
 
 #ifndef NET_HTTP_HTTP_REQUEST_HEADERS_H_
@@ skipping 82 matching lines @@
   // Gets the first header that matches |key|.  If found, returns true and
   // writes the value to |out|.
   bool GetHeader(const base::StringPiece& key, std::string* out) const;
 
   // Clears all the headers.
   void Clear();
 
   // Sets the header value pair for |key| and |value|.  If |key| already exists,
   // then the header value is modified, but the key is untouched, and the order
   // in the vector remains the same.  When comparing |key|, case is ignored.
+  // The caller must ensure that |key| passes HttpUtil::IsValidHeaderName() and
+  // |value| passes HttpUtil::IsValidHeaderValue().
   void SetHeader(const base::StringPiece& key, const base::StringPiece& value);
 
   // Sets the header value pair for |key| and |value|, if |key| does not exist.
   // If |key| already exists, the call is a no-op.
   // When comparing |key|, case is ignored.
   void SetHeaderIfMissing(const base::StringPiece& key,
                           const base::StringPiece& value);
 
   // Removes the first header that matches (case insensitive) |key|.
   void RemoveHeader(const base::StringPiece& key);
@@ skipping 62 matching lines @@
   // Allow the copy construction and operator= to facilitate copying in
   // HttpRequestHeaders.
   // TODO(willchan): Investigate to see if we can remove the need to copy
   // HttpRequestHeaders.
   // DISALLOW_COPY_AND_ASSIGN(HttpRequestHeaders);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_REQUEST_HEADERS_H_