Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: common/tsmon/iface_test.go

Issue 2225933003: tsmon: read hostname and region from config file (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: common/tsmon/iface_test.go
diff --git a/common/tsmon/iface_test.go b/common/tsmon/iface_test.go
index a7f4884f3f2eeba64908c721d89f122724ad1ab6..2d6ff28e8212a506677a0d3bfa64efc1c3dee8b7 100644
--- a/common/tsmon/iface_test.go
+++ b/common/tsmon/iface_test.go
@@ -35,6 +35,35 @@ func TestInitializeFromFlags(t *testing.T) {
So(target.GetHostname(), ShouldEqual, "autogen:test-m4")
})
+ Convey("with predefined autogenerated hostnames (Device)", func() {
+ tsmonFlags.Target.AutoGenHostname = true
+ tsmonFlags.Target.DeviceHostname = "test-m5"
+ err := InitializeFromFlags(c, &tsmonFlags)
+ So(err, ShouldBeNil)
+ defer Shutdown(c)
+
+ s := GetState(c).S
+ So(s.DefaultTarget(), ShouldHaveSameTypeAs, (*target.NetworkDevice)(nil))
+ target := s.DefaultTarget().(*target.NetworkDevice).AsProto()
+ So(target.GetHostname(), ShouldEqual, "autogen:test-m5")
+ })
+
+ Convey("with predefined autogenerated hostnames (Task)", func() {
+ tsmonFlags.Target.AutoGenHostname = true
+ tsmonFlags.Target.TaskHostname = "test-m5"
+ tsmonFlags.Target.TargetType = target.TaskType
+ tsmonFlags.Target.TaskServiceName = "test-service"
+ tsmonFlags.Target.TaskJobName = "test-job"
+ err := InitializeFromFlags(c, &tsmonFlags)
+ So(err, ShouldBeNil)
+ defer Shutdown(c)
+
+ s := GetState(c).S
+ So(s.DefaultTarget(), ShouldHaveSameTypeAs, (*target.Task)(nil))
+ target := s.DefaultTarget().(*target.Task).AsProto()
+ So(target.GetHostName(), ShouldEqual, "autogen:test-m5")
+ })
+
Convey("with static hostnames", func() {
err := InitializeFromFlags(c, &tsmonFlags)
So(err, ShouldBeNil)
@@ -46,5 +75,32 @@ func TestInitializeFromFlags(t *testing.T) {
So(target.GetHostname(), ShouldEqual, "test-m4")
})
+ Convey("with predefined static hostnames (Device)", func() {
+ tsmonFlags.Target.DeviceHostname = "test-m5"
+ err := InitializeFromFlags(c, &tsmonFlags)
+ So(err, ShouldBeNil)
+ defer Shutdown(c)
+
+ s := GetState(c).S
+ So(s.DefaultTarget(), ShouldHaveSameTypeAs, (*target.NetworkDevice)(nil))
+ target := s.DefaultTarget().(*target.NetworkDevice).AsProto()
+ So(target.GetHostname(), ShouldEqual, "test-m5")
+ })
+
+ Convey("with predefined static hostnames (Task)", func() {
+ tsmonFlags.Target.TaskHostname = "test-m5"
+ tsmonFlags.Target.TargetType = target.TaskType
+ tsmonFlags.Target.TaskServiceName = "test-service"
+ tsmonFlags.Target.TaskJobName = "test-job"
+ err := InitializeFromFlags(c, &tsmonFlags)
+ So(err, ShouldBeNil)
+ defer Shutdown(c)
+
+ s := GetState(c).S
+ So(s.DefaultTarget(), ShouldHaveSameTypeAs, (*target.Task)(nil))
+ target := s.DefaultTarget().(*target.Task).AsProto()
+ So(target.GetHostName(), ShouldEqual, "test-m5")
+ })
+
})
}
« common/tsmon/iface.go ('K') | « common/tsmon/iface.go ('k') | common/tsmon/target/flags.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698