tsmon: read hostname and region from config file

tsmon: read hostname and region from config file

BUG=617261
R=dsansome@chromium.org

Committed: https://github.com/luci/luci-go/commit/b212f77f784e12f5e96f62163890e02a4e4febb2

[Sergey Berezin, 2016-08-09 00:58:57]

PTAL

[dsansome, 2016-08-09 03:28:22]

lgtm

https://codereview.chromium.org/2225933003/diff/1/common/tsmon/config_test.go
File common/tsmon/config_test.go (right):

https://codereview.chromium.org/2225933003/diff/1/common/tsmon/config_test.go...
common/tsmon/config_test.go:49: {"endpoint": "foo",
Run gofmt

https://codereview.chromium.org/2225933003/diff/1/common/tsmon/iface.go
File common/tsmon/iface.go (right):

https://codereview.chromium.org/2225933003/diff/1/common/tsmon/iface.go#newco...
common/tsmon/iface.go:103: fl.Target.DeviceHostname = config.Hostname
I would expect flags to override values from a config file?

if config.Hostname != "" {
  if fl.Target.DeviceHostname == "" {
    fl.Target.DeviceHostname = config.Hostname
  }
  ...
}

Same for AutoGenHostname above actually.

[Sergey Berezin, 2016-08-10 01:49:16]

Thanks! I'll land this once I find the bug and fix it (the last test fails -
region is not updated from config somehow).

https://codereview.chromium.org/2225933003/diff/1/common/tsmon/config_test.go
File common/tsmon/config_test.go (right):

https://codereview.chromium.org/2225933003/diff/1/common/tsmon/config_test.go...
common/tsmon/config_test.go:49: {"endpoint": "foo",
On 2016/08/09 03:28:22, dsansome wrote:
> Run gofmt

Actually, this is part of the `string`, so gofmt doesn't care.
But, good point, I'll format it nicer.

https://codereview.chromium.org/2225933003/diff/1/common/tsmon/iface.go
File common/tsmon/iface.go (right):

https://codereview.chromium.org/2225933003/diff/1/common/tsmon/iface.go#newco...
common/tsmon/iface.go:103: fl.Target.DeviceHostname = config.Hostname
On 2016/08/09 03:28:22, dsansome wrote:
> I would expect flags to override values from a config file?

Good catch, thanks! Done.

> 
> if config.Hostname != "" {
>   if fl.Target.DeviceHostname == "" {
>     fl.Target.DeviceHostname = config.Hostname
>   }
>   ...
> }
> 
> Same for AutoGenHostname above actually.

For AutoGenHostname, it'll be set to true when either config or command line
flag sets it. I think this is still an expected behavior.

[Sergey Berezin, 2016-08-13 00:40:19]

The CQ bit was checked by sergeyberezin@chromium.org

[Sergey Berezin, 2016-08-13 00:40:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsansome@chromium.org
Link to the patchset: https://codereview.chromium.org/2225933003/#ps40001
(title: "Fixed error in test")

[commit-bot: I haz the power, 2016-08-13 00:40:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-13 00:48:08]

Description was changed from

==========
tsmon: read hostname and region from config file

BUG=617261
R=dsansome@chromium.org
==========

to

==========
tsmon: read hostname and region from config file

BUG=617261
R=dsansome@chromium.org

Committed:
https://github.com/luci/luci-go/commit/b212f77f784e12f5e96f62163890e02a4e4febb2
==========

[commit-bot: I haz the power, 2016-08-13 00:48:09]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/b212f77f784e12f5e96f62163890e02a4e4febb2