[Interpreter] Collect type feedback for 'new' in the bytecode handler

[Interpreter] Collect type feedback for 'new' in the bytecode handler

Collect type feedback in the bytecode handler for 'new' bytecode. The
earlier cl (https://codereview.chromium.org/2153433002/) was reverted
because that implementation did not collect allocation site feedback.
This regressed delta blue by an order of magnitude. This implementation
includes collection of allocation site feedback.

Reland of https://codereview.chromium.org/2190293003/ with a bug fix.

BUG=v8:4280, v8:4780
LOG=N

Committed: https://crrev.com/7e5b8feed307288d602c11cb4fb1184cbbc21d5a
Cr-Commit-Position: refs/heads/master@{#39120}

[mythria, 2016-08-31 15:52:05]

The CQ bit was checked by mythria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 15:52:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 16:16:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 16:16:24]

Dry run: This issue passed the CQ dry run.

[mythria, 2016-09-01 08:22:25]

Description was changed from

==========
[Interpreter] Collect type feedback for 'new' in the bytecode handler

Collect type feedback in the bytecode handler for 'new' bytecode. The
earlier cl (https://codereview.chromium.org/2153433002/) was reverted
because that implementation did not collect allocation site feedback.
This regressed delta blue by an order of magnitude. This implementation
includes collection of allocation site feedback.

BUG=v8:4280, v8:4780
LOG=N
==========

to

==========
[Interpreter] Collect type feedback for 'new' in the bytecode handler

Reland of https://codereview.chromium.org/2190293003/ with a bug fix.

Collect type feedback in the bytecode handler for 'new' bytecode. The
earlier cl (https://codereview.chromium.org/2153433002/) was reverted
because that implementation did not collect allocation site feedback.
This regressed delta blue by an order of magnitude. This implementation
includes collection of allocation site feedback.

BUG=v8:4280, v8:4780
LOG=N
==========

[mythria, 2016-09-01 08:22:55]

Description was changed from

==========
[Interpreter] Collect type feedback for 'new' in the bytecode handler

Reland of https://codereview.chromium.org/2190293003/ with a bug fix.

Collect type feedback in the bytecode handler for 'new' bytecode. The
earlier cl (https://codereview.chromium.org/2153433002/) was reverted
because that implementation did not collect allocation site feedback.
This regressed delta blue by an order of magnitude. This implementation
includes collection of allocation site feedback.

BUG=v8:4280, v8:4780
LOG=N
==========

to

==========
[Interpreter] Collect type feedback for 'new' in the bytecode handler

Collect type feedback in the bytecode handler for 'new' bytecode. The
earlier cl (https://codereview.chromium.org/2153433002/) was reverted
because that implementation did not collect allocation site feedback.
This regressed delta blue by an order of magnitude. This implementation
includes collection of allocation site feedback.

Reland of https://codereview.chromium.org/2190293003/ with a bug fix.

BUG=v8:4280, v8:4780
LOG=N
==========

[mythria, 2016-09-01 08:42:23]

mythria@chromium.org changed reviewers:
+ bmeurer@chromium.org, rmcilroy@chromium.org

[mythria, 2016-09-01 08:42:24]

Benedikt,

I am trying to reland the cl that collects feedback for 'new' bytecode. The
earlier cl (https://codereview.chromium.org/2190293003/) got reverted because it
was failing on few bots.

It was failing because InterpreterPushArgsAndConstruct did not initialize the
slot meant for receiver. It contained return address, and the verify heap was
interpreting that as an object which caused it to fail. I fixed it now. This is
the only change on the top of earlier cl. Other architectures do not have this
problem. We push 0 in other architectures. 

I am sorry for the delay, it required some dedicated time to debug this and I
could not do it during my vacation.

PTAL.

Thanks,
Mythri

https://codereview.chromium.org/2225923003/diff/80001/src/builtins/ia32/built...
File src/builtins/ia32/builtins-ia32.cc (right):

https://codereview.chromium.org/2225923003/diff/80001/src/builtins/ia32/built...
src/builtins/ia32/builtins-ia32.cc:842: __ mov(Operand(esp, eax,
times_pointer_size, 3 * kPointerSize), Immediate(0));
This is the only change on the top of the earlier cl
(https://codereview.chromium.org/2190293003/) that got reverted.

[Benedikt Meurer, 2016-09-02 05:13:11]

Nice, thanks again for doing this work. LGTM.

[Benedikt Meurer, 2016-09-02 05:13:19]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-09-02 05:13:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 05:15:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 05:15:17]

Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/11953)

[mythria, 2016-09-02 07:52:02]

The CQ bit was checked by mythria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 07:52:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 08:20:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 08:20:30]

Dry run: This issue passed the CQ dry run.

[mythria, 2016-09-02 08:24:14]

The CQ bit was checked by mythria@chromium.org

[commit-bot: I haz the power, 2016-09-02 08:24:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 08:26:43]

Description was changed from

==========
[Interpreter] Collect type feedback for 'new' in the bytecode handler

Collect type feedback in the bytecode handler for 'new' bytecode. The
earlier cl (https://codereview.chromium.org/2153433002/) was reverted
because that implementation did not collect allocation site feedback.
This regressed delta blue by an order of magnitude. This implementation
includes collection of allocation site feedback.

Reland of https://codereview.chromium.org/2190293003/ with a bug fix.

BUG=v8:4280, v8:4780
LOG=N
==========

to

==========
[Interpreter] Collect type feedback for 'new' in the bytecode handler

Collect type feedback in the bytecode handler for 'new' bytecode. The
earlier cl (https://codereview.chromium.org/2153433002/) was reverted
because that implementation did not collect allocation site feedback.
This regressed delta blue by an order of magnitude. This implementation
includes collection of allocation site feedback.

Reland of https://codereview.chromium.org/2190293003/ with a bug fix.

BUG=v8:4280, v8:4780
LOG=N
==========

[commit-bot: I haz the power, 2016-09-02 08:26:44]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-02 08:27:02]

Description was changed from

==========
[Interpreter] Collect type feedback for 'new' in the bytecode handler

Collect type feedback in the bytecode handler for 'new' bytecode. The
earlier cl (https://codereview.chromium.org/2153433002/) was reverted
because that implementation did not collect allocation site feedback.
This regressed delta blue by an order of magnitude. This implementation
includes collection of allocation site feedback.

Reland of https://codereview.chromium.org/2190293003/ with a bug fix.

BUG=v8:4280, v8:4780
LOG=N
==========

to

==========
[Interpreter] Collect type feedback for 'new' in the bytecode handler

Collect type feedback in the bytecode handler for 'new' bytecode. The
earlier cl (https://codereview.chromium.org/2153433002/) was reverted
because that implementation did not collect allocation site feedback.
This regressed delta blue by an order of magnitude. This implementation
includes collection of allocation site feedback.

Reland of https://codereview.chromium.org/2190293003/ with a bug fix.

BUG=v8:4280, v8:4780
LOG=N

Committed: https://crrev.com/7e5b8feed307288d602c11cb4fb1184cbbc21d5a
Cr-Commit-Position: refs/heads/master@{#39120}
==========

[commit-bot: I haz the power, 2016-09-02 08:27:04]

Patchset 5 (id:??) landed as
https://crrev.com/7e5b8feed307288d602c11cb4fb1184cbbc21d5a
Cr-Commit-Position: refs/heads/master@{#39120}