Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2225903003: mac: Make build documentation less out-of-date. (Closed)

Created:
4 years, 4 months ago by Nico
Modified:
4 years, 4 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Make build documentation less out-of-date. BUG= Committed: https://crrev.com/f28551b93dc6799fa8958a022f0d222c6152afb4 Cr-Commit-Position: refs/heads/master@{#410668}

Patch Set 1 #

Patch Set 2 : be less excited about xcode #

Total comments: 2

Patch Set 3 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -116 lines) Patch
M docs/mac_build_instructions.md View 1 2 8 chunks +47 lines, -116 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Nico
mostly s/gyp/gn/ and also remove a random emacs section that seems out of place. we ...
4 years, 4 months ago (2016-08-09 01:55:21 UTC) #4
Robert Sesek
lgtm https://codereview.chromium.org/2225903003/diff/20001/docs/mac_build_instructions.md File docs/mac_build_instructions.md (right): https://codereview.chromium.org/2225903003/diff/20001/docs/mac_build_instructions.md#newcode40 docs/mac_build_instructions.md:40: to generate build files (replace "gn" with whatever ...
4 years, 4 months ago (2016-08-09 12:16:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225903003/40001
4 years, 4 months ago (2016-08-09 14:07:51 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-09 14:43:16 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 14:48:27 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f28551b93dc6799fa8958a022f0d222c6152afb4
Cr-Commit-Position: refs/heads/master@{#410668}

Powered by Google App Engine
This is Rietveld 408576698