Issue 22259008: file_manager: Rename file_watcher_extensions.h to file_watcher.h

Issue 22259008: file_manager: Rename file_watcher_extensions.h to file_watcher.h (Closed)

Created:
7 years, 4 months ago by satorux1

Modified:
7 years, 4 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

file_manager: Rename file_watcher_extensions.h to file_watcher.h Rename the class name as well. "extensions" in the file name and the class name don't make much sense. Along the way, add lots of comments and make some cosmetic changes, but no semantic changes. BUG=268248 TEST=none R=hashimoto@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215828

Patch Set 1 : #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+128 lines, -219 lines)			Patch
M	chrome/browser/chromeos/extensions/file_manager/event_router.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/event_router.cc	View	2 chunks	+6 lines, -10 lines	0 comments	Download
A	chrome/browser/chromeos/extensions/file_manager/file_watcher.h	View	1 chunk	+100 lines, -0 lines	1 comment	Download
A +	chrome/browser/chromeos/extensions/file_manager/file_watcher.cc	View	5 chunks	+17 lines, -15 lines	0 comments	Download
D	chrome/browser/chromeos/extensions/file_manager/file_watcher_extensions.h	View	1 chunk	+0 lines, -69 lines	0 comments	Download
D	chrome/browser/chromeos/extensions/file_manager/file_watcher_extensions.cc	View	1 chunk	+0 lines, -120 lines	0 comments	Download
M	chrome/chrome_browser_chromeos.gypi	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

satorux1

https://codereview.chromium.org/22259008/diff/18001/chrome/browser/chromeos/extensions/file_manager/file_watcher.h File chrome/browser/chromeos/extensions/file_manager/file_watcher.h (right): https://codereview.chromium.org/22259008/diff/18001/chrome/browser/chromeos/extensions/file_manager/file_watcher.h#newcode1 chrome/browser/chromeos/extensions/file_manager/file_watcher.h:1: // Copyright 2013 The Chromium Authors. All rights reserved. ...

7 years, 4 months ago (2013-08-06 05:19:31 UTC) #2

satorux1

7 years, 4 months ago (2013-08-06 06:33:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r215828 (presubmit successful).

Expand Messages | Collapse Messages