Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2225893003: Provide LINE_INFO from ResynthesizerResultProvider. (Closed)

Created:
4 years, 4 months ago by scheglov
Modified:
4 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Provide LINE_INFO from ResynthesizerResultProvider. Also, to guarantee that LINE_INFO is computed, we need to replace context.getLineInfo() with context.computeLineInfo() in the server. This should be equivalently fast in both summary (from provider) and non-summary cases (the source should have been scanned and parsed in order to resolve references to its elements). R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/43fef756ae79b614ad6ff87995430d5059d51626

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -24 lines) Patch
M pkg/analysis_server/lib/src/protocol_server.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/summary/package_bundle_reader.dart View 2 chunks +10 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 2 chunks +4 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/summary/package_bundle_reader_test.dart View 2 chunks +14 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 2 chunks +1 line, -4 lines 0 comments Download
M pkg/analyzer/test/src/summary/summarize_ast_test.dart View 4 chunks +5 lines, -7 lines 0 comments Download
M pkg/analyzer_cli/lib/src/build_mode.dart View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 4 months ago (2016-08-09 02:10:18 UTC) #1
Brian Wilkerson
lgtm
4 years, 4 months ago (2016-08-09 14:01:52 UTC) #2
scheglov
4 years, 4 months ago (2016-08-09 16:12:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
43fef756ae79b614ad6ff87995430d5059d51626 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698