Upload LocalGTestTest results to test-results.

Upload LocalGTestTest results to test-results.

BUG=

Committed: https://chromium.googlesource.com/chromium/tools/build/+/a2c5c12a068bbd21fef24d9158451c76e8aac935

[jbudorick, 2016-08-08 15:08:45]

jbudorick@chromium.org changed reviewers:
+ martiniss@chromium.org, stip@chromium.org

[martiniss, 2016-08-08 18:51:43]

I don't know this code that well. Change looks fine, but I would check with a
chromium tests owner (stip probably is fine). This is affecting a lot more tests
than just android it seems.

[ghost stip (do not use), 2016-08-08 21:01:15]

I'm suspicious of this change. It looks good, but I'm surprised it wasn't there
already. Is there some context or a bug I can look at?

[jbudorick, 2016-08-08 21:05:40]

On 2016/08/08 21:01:15, stip wrote:
> I'm suspicious of this change. It looks good, but I'm surprised it wasn't
there
> already. Is there some context or a bug I can look at?

From
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType...

Data is missing for builders:
chromium.linux:Cast Linux
chromium.mac:Mac10.10 Tests
chromium.android:Marshmallow 64 bit Tester
chromium.android:KitKat Tablet Tester
chromium.linux:Android Tests (dbg)
chromium.android:Lollipop Phone Tester
chromium.mac:Mac10.11 Tests
chromium.android:Lollipop Low-end Tester
chromium.android:Jelly Bean Tester
chromium.android:Lollipop Consumer Tester
chromium.android:Lollipop Tablet Tester
chromium.android:Marshmallow Tablet Tester


instrumentation tests had the same problem until I fixed that a few months ago.

[jbudorick, 2016-08-08 21:07:52]

On 2016/08/08 21:05:40, jbudorick wrote:
> On 2016/08/08 21:01:15, stip wrote:
> > I'm suspicious of this change. It looks good, but I'm surprised it wasn't
> there
> > already. Is there some context or a bug I can look at?
> 
> From
>
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType...
> 
> Data is missing for builders:
> chromium.linux:Cast Linux
> chromium.mac:Mac10.10 Tests
> chromium.android:Marshmallow 64 bit Tester
> chromium.android:KitKat Tablet Tester
> chromium.linux:Android Tests (dbg)
> chromium.android:Lollipop Phone Tester
> chromium.mac:Mac10.11 Tests
> chromium.android:Lollipop Low-end Tester
> chromium.android:Jelly Bean Tester
> chromium.android:Lollipop Consumer Tester
> chromium.android:Lollipop Tablet Tester
> chromium.android:Marshmallow Tablet Tester
> 
> 
> instrumentation tests had the same problem until I fixed that a few months
ago.

(and this goes for the other gtest suites)

[ghost stip (do not use), 2016-08-08 22:57:53]

lgtm, be prepared to revert if there is mayhem. let the trooper know

[jbudorick, 2016-08-08 23:42:51]

On 2016/08/08 22:57:53, stip wrote:
> lgtm, be prepared to revert if there is mayhem. let the trooper know

trooper has been warned.

[jbudorick, 2016-08-08 23:42:57]

The CQ bit was checked by jbudorick@chromium.org

[jbudorick, 2016-08-08 23:42:58]

The patchset sent to the CQ was uploaded after l-g-t-m from stip@chromium.org
Link to the patchset: https://codereview.chromium.org/2225893002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-08 23:43:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 23:47:09]

Description was changed from

==========
Upload LocalGTestTest results to test-results.

BUG=
==========

to

==========
Upload LocalGTestTest results to test-results.

BUG=

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/a2c5c12a068bbd21fef2...
==========

[commit-bot: I haz the power, 2016-08-08 23:47:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/a2c5c12a068bbd21fef2...

[jbudorick, 2016-08-09 00:17:44]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2228763002/ by jbudorick@chromium.org.

The reason for reverting is: Downstream concerns..

[jbudorick, 2016-08-09 01:07:26]

On 2016/08/09 00:17:44, jbudorick wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/2228763002/ by mailto:jbudorick@chromium.org.
> 
> The reason for reverting is: Downstream concerns..

FWIW, this works:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...